Skip to content

Commit

Permalink
Use logger formatting instead of string interpolation.
Browse files Browse the repository at this point in the history
Follow-up to ilevy's comments in https://chromiumcodereview.appspot.com/14759006/

Review URL: https://chromiumcodereview.appspot.com/14874005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@198236 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
[email protected] committed May 3, 2013
1 parent 12b07e7 commit c144e06
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions gclient_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -745,17 +745,17 @@ def run(self):
try:
self.item.run(*self.args, **self.kwargs)
except KeyboardInterrupt:
logging.info('Caught KeyboardInterrupt in thread %s' % self.item.name)
logging.info('Caught KeyboardInterrupt in thread %s', self.item.name)
logging.info(str(sys.exc_info()))
work_queue.exceptions.put(sys.exc_info())
raise
except Exception:
# Catch exception location.
logging.info('Caught exception in thread %s' % self.item.name)
logging.info('Caught exception in thread %s', self.item.name)
logging.info(str(sys.exc_info()))
work_queue.exceptions.put(sys.exc_info())
finally:
logging.info('_Worker.run(%s) done' % self.item.name)
logging.info('_Worker.run(%s) done', self.item.name)
work_queue.ready_cond.acquire()
try:
work_queue.ready_cond.notifyAll()
Expand Down

0 comments on commit c144e06

Please sign in to comment.