Skip to content

Commit

Permalink
Fix broken E2E tests on Linux machines (#135394)
Browse files Browse the repository at this point in the history
Summary:
I'm not entirely sure why this is failing with an `ImportError` (according to lastnameye a super class of `ModuleNotFoundError`s), but on our E2E tests on Linux machines (but not Macs?), we're seeing the import failure not getting caught --
`ImportError: cannot import name 'parutil' from 'libfb.py' (/data/sandcastle/boxes/eden-trunk-hg-full-fbsource/buck-out/v2/gen/fbsource/d0c916ec8d40ce11/arvr/libraries/ctrl/studies/replay/__ctrl-r__/ctrl-r#link-tree/libfb/py/__init__.py)` from this test run https://www.internalfb.com/sandcastle/workflow/2522015791331601269, an instance of this job:  https://www.internalfb.com/intern/test/844425085172858?ref_report_id=0 is the overall job

Test Plan:
`arc skycastle schedule tools/skycastle/workflows2/ctrl/js_tests.sky:test_js_e2e_replay_tests --sandcastle-spec-overrides '{"type": "fbcode", "unicastle_size": "I1_MEDIUM"}'`
->
https://www.internalfb.com/sandcastle/workflow/256705178764255769

Differential Revision: D62321167

Pull Request resolved: pytorch/pytorch#135394
Approved by: https://github.com/laithsakka
  • Loading branch information
maclyn authored and pytorchmergebot committed Sep 9, 2024
1 parent 5b368de commit cbc6b30
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion torch/_inductor/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -589,7 +589,7 @@ def decide_compile_threads() -> int:
)
else:
global_cache_dir = parutil.get_dir_path("fb/cache")
except (ValueError, ModuleNotFoundError):
except (ValueError, ImportError):
global_cache_dir = None

else:
Expand Down

0 comments on commit cbc6b30

Please sign in to comment.