Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(text-field): Show clear button in TextField only when it is fille…
…d and hovered/focused (channel-io#1713) <!-- How to write a good PR title: - Follow [the Conventional Commits specification](https://www.conventionalcommits.org/en/v1.0.0/). - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ## Self Checklist - [x] I wrote a PR title in **English** and added an appropriate **label** to the PR. - [x] I wrote the commit message in **English** and to follow [**the Conventional Commits specification**](https://www.conventionalcommits.org/en/v1.0.0/). - [x] I [added the **changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md) about the changes that needed to be released. (or didn't have to) - [x] I wrote or updated **documentation** related to the changes. (or didn't have to) - [x] I wrote or updated **tests** related to the changes. (or didn't have to) - [x] I tested the changes in various browsers. (or didn't have to) - Windows: Chrome, Edge, (Optional) Firefox - macOS: Chrome, Edge, Safari, (Optional) Firefox ## Related Issue <!-- Please link to issue if one exists --> Fixes channel-io#502 ## Summary <!-- Please brief explanation of the changes made --> input에 값이 채워져있고, focus되거나 hover되었을 때만 내용 삭제 버튼이 나오도록 변경합니다. ## Details <!-- Please elaborate description of the changes --> ```tsx // TextField.tsx // before const activeClear = activeInput && allowClear // after const activeClear = activeInput && allowClear && !!normalizedValue return ( ... { activeClear && ClearComponent } ... ) ``` 기존에 `ClearComponent` 의 렌더링 조건에는 `value`에 대한 것이 없었습니다. 그래서 `!!normalizedValue`를 통해 input 태그에 값이 있어야지만 내용 삭제 버튼이 렌더링되도록 하였습니다. ### Breaking change? (Yes/No) <!-- If Yes, please describe the impact and migration path for users --> No
- Loading branch information