Skip to content

Commit

Permalink
chore!: require Node.js v20 instead of v18 (speced#4680)
Browse files Browse the repository at this point in the history
  • Loading branch information
sidvishnoi authored Apr 11, 2024
1 parent 0eb2a8f commit 0af7379
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 11 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
echo "::error::Uh oh! builds/ was changed."; exit 1
- uses: pnpm/action-setup@v3
- uses: actions/setup-node@v4
with: { node-version: 18, cache: pnpm }
with: { node-version-file: '.nvmrc', cache: pnpm }
- run: pnpm i --frozen-lockfile
- run: pnpm lint

Expand All @@ -45,7 +45,7 @@ jobs:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v3
- uses: actions/setup-node@v4
with: { node-version: 18, cache: pnpm }
with: { node-version-file: '.nvmrc', cache: pnpm }
- run: pnpm i --frozen-lockfile
- run: pnpm test:build
- run: pnpm build:w3c
Expand All @@ -62,7 +62,7 @@ jobs:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v3
- uses: actions/setup-node@v4
with: { node-version: 18, cache: pnpm }
with: { node-version-file: '.nvmrc', cache: pnpm }
- run: pnpm i --frozen-lockfile
- run: pnpm build:w3c & pnpm build:geonovum
- run: pnpm test:unit
Expand All @@ -80,7 +80,7 @@ jobs:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v3
- uses: actions/setup-node@v4
with: { node-version: 18, cache: pnpm }
with: { node-version-file: '.nvmrc', cache: pnpm }
- run: pnpm i --frozen-lockfile
- run: pnpm build:w3c
- name: run validator
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v3
- uses: actions/setup-node@v4
with: { node-version: 18, cache: pnpm }
with: { node-version-file: '.nvmrc', cache: pnpm }
- run: pnpm i --frozen-lockfile
- run: pnpm build:w3c
- run: pnpm test:headless
Expand All @@ -55,7 +55,7 @@ jobs:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v3
- uses: actions/setup-node@v4
with: { node-version: 18, cache: pnpm }
with: { node-version-file: '.nvmrc', cache: pnpm }
- run: pnpm i --frozen-lockfile
- run: pnpm build:w3c & pnpm build:geonovum
- run: pnpm test
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/regressions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v3
- uses: actions/setup-node@v4
with: { node-version: 18, cache: pnpm }
with: { node-version-file: '.nvmrc', cache: pnpm }
- run: pnpm i --frozen-lockfile
- run: pnpm build:w3c
- uses: actions/upload-artifact@v4
Expand Down Expand Up @@ -44,7 +44,7 @@ jobs:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v3
- uses: actions/setup-node@v4
with: { node-version: 18, cache: pnpm }
with: { node-version-file: '.nvmrc', cache: pnpm }
- run: pnpm i --frozen-lockfile
- uses: actions/download-artifact@v4
with:
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18
20
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
"license": "W3C",
"description": "A technical specification pre-processor.",
"engines": {
"node": ">=18.14"
"node": ">=20.12.1"
},
"packageManager": "[email protected].4",
"packageManager": "[email protected].6",
"bin": {
"respec": "tools/respec2html.js",
"respec2html": "tools/respec2html.js"
Expand Down

0 comments on commit 0af7379

Please sign in to comment.