chore!: require Node 18; use pnpm (speced#4416)

BREAKING CHANGE: Require Node v18.14+
jirkakad1994 · Apr 5, 2023 · c96023a · c96023a
1 parent e75e42f
commit c96023a
Show file tree

Hide file tree

Showing 11 changed files with 3,827 additions and 11,090 deletions.
diff --git a/.github/dependabot.yml b/.github/dependabot.yml
@@ -1,13 +1,14 @@
 version: 2
 updates:
-  - package-ecosystem: npm
-    directory: "/"
-    schedule:
-      interval: weekly
-      time: "10:00"
-    open-pull-requests-limit: 10
-    labels: [dependencies]
-    versioning-strategy: increase
+  # # pnpm support coming soon: https://github.com/dependabot/dependabot-core/issues/1736#issuecomment-1489987159
+  # - package-ecosystem: npm
+  #   directory: "/"
+  #   schedule:
+  #     interval: weekly
+  #     time: "10:00"
+  #   open-pull-requests-limit: 10
+  #   labels: [dependencies]
+  #   versioning-strategy: increase
 
   - package-ecosystem: github-actions
     directory: "/"

diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml
@@ -30,23 +30,25 @@ jobs:
           curl -sL https://api.github.com/repos/w3c/respec/pulls/${{ github.event.pull_request.number }}/files -o /tmp/pr_files.json
           cat /tmp/pr_files.json | jq -r '.[].filename' | grep -qE "^builds/" || exit 0
           echo "::error::Uh oh! builds/ was changed."; exit 1
+      - uses: pnpm/action-setup@v2
       - uses: actions/setup-node@v3
-        with: { node-version: 16, cache: npm }
-      - run: npm ci
-      - run: npm run lint
+        with: { node-version: 18, cache: pnpm }
+      - run: pnpm i --frozen-lockfile
+      - run: pnpm lint
 
   test-headless:
     name: Headless Tests
     runs-on: ubuntu-latest
     needs: lint
     steps:
       - uses: actions/checkout@v3
+      - uses: pnpm/action-setup@v2
       - uses: actions/setup-node@v3
-        with: { node-version: 16, cache: npm }
-      - run: npm ci
-      - run: npm run test:build
-      - run: npm run build:w3c
-      - run: npm run test:headless
+        with: { node-version: 18, cache: pnpm }
+      - run: pnpm i --frozen-lockfile
+      - run: pnpm test:build
+      - run: pnpm build:w3c
+      - run: pnpm test:headless
 
   test-karma:
     name: Karma Unit Tests (${{ matrix.browser }})
@@ -57,16 +59,15 @@ jobs:
     needs: lint
     steps:
       - uses: actions/checkout@v3
+      - uses: pnpm/action-setup@v2
       - uses: actions/setup-node@v3
-        with: { node-version: 16, cache: npm }
-      - name: install & build
-        run: |
-          npm ci
-          npm run build:w3c & npm run build:geonovum
-      - run: npm run test:unit
+        with: { node-version: 18, cache: pnpm }
+      - run: pnpm i --frozen-lockfile
+      - run: pnpm build:w3c & pnpm build:geonovum
+      - run: pnpm test:unit
         env:
           BROWSERS: ${{ matrix.browser }}
-      - run: npm run test:integration
+      - run: pnpm test:integration
         env:
           BROWSERS: ${{ matrix.browser }}
 
@@ -76,12 +77,11 @@ jobs:
     needs: lint
     steps:
       - uses: actions/checkout@v3
+      - uses: pnpm/action-setup@v2
       - uses: actions/setup-node@v3
-        with: { node-version: 16, cache: npm }
-      - name: install & build
-        run: |
-          npm ci
-          npm run build:w3c
+        with: { node-version: 18, cache: pnpm }
+      - run: pnpm i --frozen-lockfile
+      - run: pnpm build:w3c
       - name: run validator
         run: |
           vnu=$(node -p "require('vnu-jar')")

diff --git a/.github/workflows/push.yml b/.github/workflows/push.yml
@@ -27,13 +27,12 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
+      - uses: pnpm/action-setup@v2
       - uses: actions/setup-node@v3
-        with: { node-version: 16, cache: npm }
-      - name: install & build
-        run: |
-          npm ci
-          npm run build:w3c
-      - run: npm run test:headless
+        with: { node-version: 18, cache: pnpm }
+      - run: pnpm i --frozen-lockfile
+      - run: pnpm build:w3c
+      - run: pnpm test:headless
       - name: Calculate size and update on server
         run: |
           timestamp=$(git show --no-patch --pretty='%cd' --date='format:%s')
@@ -53,12 +52,11 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
+      - uses: pnpm/action-setup@v2
       - uses: actions/setup-node@v3
-        with: { node-version: 16, cache: npm }
-      - name: install & build
-        run: |
-          npm ci
-          npm run build:w3c & npm run build:geonovum
-      - run: npm test
+        with: { node-version: 18, cache: pnpm }
+      - run: pnpm i --frozen-lockfile
+      - run: pnpm build:w3c & pnpm build:geonovum
+      - run: pnpm test
         env:
           BROWSERS: ChromeHeadless
diff --git a/.github/workflows/regressions.yml b/.github/workflows/regressions.yml
@@ -12,10 +12,11 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
+      - uses: pnpm/action-setup@v2
       - uses: actions/setup-node@v3
-        with: { node-version: 16, cache: npm }
-      - run: npm ci
-      - run: npm run build:w3c
+        with: { node-version: 18, cache: pnpm }
+      - run: pnpm i --frozen-lockfile
+      - run: pnpm build:w3c
       - uses: actions/upload-artifact@v3
         with:
           name: builds
@@ -41,9 +42,10 @@ jobs:
       fail-fast: false
     steps:
       - uses: actions/checkout@v3
+      - uses: pnpm/action-setup@v2
       - uses: actions/setup-node@v3
-        with: { node-version: 16, cache: npm }
-      - run: npm ci --production --ignore-scripts
+        with: { node-version: 18, cache: pnpm }
+      - run: pnpm i --frozen-lockfile
       - uses: actions/download-artifact@v3
         with:
           name: builds

diff --git a/.gitignore b/.gitignore
@@ -12,5 +12,6 @@ js/deps/builds
 !js/profile-w3c.js
 .vscode/*
 !.vscode/tasks.json
-pnpm-lock.yaml
+package-lock.json
+yarn.lock
 *.log
diff --git a/.nvmrc b/.nvmrc
@@ -0,0 +1 @@
+18