Option to limit amount of unrolled elements

jizhuwojiaopaozong · Aug 21, 2019 · b43998f · b43998f
1 parent f46ccab
commit b43998f
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 0 deletions.
diff --git a/packages/abbreviation/src/convert.ts b/packages/abbreviation/src/convert.ts
@@ -14,6 +14,7 @@ export default function convert(abbr: TokenGroup, options: ParserOptions = {}):
             inserted: false,
             repeaters: [],
             text: options.text,
+            repeatGuard: options.maxRepeat || Number.POSITIVE_INFINITY,
             getText(pos) {
                 const value = Array.isArray(options.text)
                     ? (pos != null ? options.text[pos] : options.text.join('\n'))
@@ -65,6 +66,12 @@ function convertStatement(node: TokenStatement, state: ConvertState): Abbreviati
             }
 
             result = result.concat(items);
+
+            // We should output at least one repeated item even if it’s reached
+            // repeat limit
+            if (--state.repeatGuard <= 0) {
+                break;
+            }
         }
 
         state.repeaters.pop();

diff --git a/packages/abbreviation/src/types.ts b/packages/abbreviation/src/types.ts
@@ -3,11 +3,13 @@ import { Field, Repeater } from './tokenizer';
 export interface ParserOptions {
     text?: string | string[];
     variables?: { [name: string]: string };
+    maxRepeat?: number;
 }
 
 export interface ConvertState {
     inserted: boolean;
     text?: string | string[];
+    repeatGuard: number;
 
     /** Context repeaters, e.g. all actual repeaters from parent */
     repeaters: Repeater[];

diff --git a/packages/abbreviation/test/convert.ts b/packages/abbreviation/test/convert.ts
@@ -33,4 +33,11 @@ describe('Convert token abbreviations', () => {
         equal(parse('p>{foo}>div'), '<p><?>foo</?><div></div></p>');
         equal(parse('p>{foo ${0}}>div'), '<p><?>foo ${0}<div></div></?></p>');
     });
+
+    it('limit unroll', () => {
+        // Limit amount of repeated elements
+        equal(parse('a*10', { maxRepeat: 5 }), '<a*10@0></a><a*10@1></a><a*10@2></a><a*10@3></a><a*10@4></a>');
+        equal(parse('a*10'), '<a*10@0></a><a*10@1></a><a*10@2></a><a*10@3></a><a*10@4></a><a*10@5></a><a*10@6></a><a*10@7></a><a*10@8></a><a*10@9></a>');
+        equal(parse('a*3>b*3', { maxRepeat: 5 }), '<a*3@0><b*3@0></b><b*3@1></b><b*3@2></b></a><a*3@1><b*3@0></b></a>');
+    });
 });
diff --git a/src/config/types.ts b/src/config/types.ts
@@ -40,6 +40,9 @@ interface ResolvedConfig extends BaseConfig {
 
     /** Text to wrap with abbreviation */
     text?: string | string[];
+
+    /** Max amount of repeated elements (fool proof) */
+    maxRepeat?: number;
 }
 
 export type Config = ResolvedConfig & { options: Options };