Use frozen string literal in Active Storage

.rubocop.yml

@@ -88,6 +88,7 @@ Style/FrozenStringLiteralComment:
     - 'actioncable/**/*'
     - 'activejob/**/*'
     - 'activerecord/**/*'
+    - 'activestorage/**/*'
     - 'actionmailer/**/*'
     - 'actionview/**/*'
     - 'actionpack/**/*'

activestorage/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "bundler/setup"
 require "bundler/gem_tasks"
 require "rake/testtask"

activestorage/app/controllers/active_storage/blobs_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Take a signed permanent reference for a blob and turn it into an expiring service URL for download.
 # Note: These URLs are publicly accessible. If you need to enforce access protection beyond the
 # security-through-obscurity factor of the signed blob references, you'll need to implement your own

activestorage/app/controllers/active_storage/direct_uploads_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Creates a new blob on the server side in anticipation of a direct-to-service upload from the client side.
 # When the client-side upload is completed, the signed_blob_id can be submitted as part of the form to reference
 # the blob that was created up front.

activestorage/app/controllers/active_storage/disk_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Serves files stored with the disk service in the same way that the cloud services do.
 # This means using expiring, signed URLs that are meant for immediate access, not permanent linking.
 # Always go through the BlobsController, or your own authenticated controller, rather than directly

activestorage/app/controllers/active_storage/variants_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Take a signed permanent reference for a variant and turn it into an expiring service URL for download.
 # Note: These URLs are publicly accessible. If you need to enforce access protection beyond the
 # security-through-obscurity factor of the signed blob and variation reference, you'll need to implement your own

activestorage/app/jobs/active_storage/purge_job.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Provides delayed purging of attachments or blobs using their +#purge_later+ method.
 class ActiveStorage::PurgeJob < ActiveJob::Base
   # FIXME: Limit this to a custom ActiveStorage error

activestorage/app/models/active_storage/attachment.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "active_support/core_ext/module/delegation"
 
 # Attachments associate records with blobs. Usually that's a one record-many blobs relationship,

activestorage/app/models/active_storage/blob.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # A blob is a record that contains the metadata about a file and a key for where that file resides on the service.
 # Blobs can be created in two ways:
 #

activestorage/app/models/active_storage/filename.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Encapsulates a string representing a filename to provide convenience access to parts of it and a sanitized version.
 # This is what's returned by `ActiveStorage::Blob#filename`. A Filename instance is comparable so it can be used for sorting.
 class ActiveStorage::Filename

activestorage/app/models/active_storage/variant.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Image blobs can have variants that are the result of a set of transformations applied to the original.
 # These variants are used to create thumbnails, fixed-size avatars, or any other derivative image from the
 # original.

activestorage/app/models/active_storage/variation.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "active_support/core_ext/object/inclusion"
 
 # A set of transformations that can be applied to a blob to create a variant. This class is exposed via

activestorage/config/routes.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Rails.application.routes.draw do
   get "/rails/active_storage/blobs/:signed_id/*filename" => "active_storage/blobs#show", as: :rails_service_blob
 

activestorage/db/migrate/20170806125915_create_active_storage_tables.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class CreateActiveStorageTables < ActiveRecord::Migration[5.1]
   def change
     create_table :active_storage_blobs do |t|

activestorage/lib/active_storage.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #--
 # Copyright (c) 2017 David Heinemeier Hansson
 #

activestorage/lib/active_storage/attached.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "action_dispatch"
 require "action_dispatch/http/upload"
 require "active_support/core_ext/module/delegation"

activestorage/lib/active_storage/attached/macros.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveStorage
   # Provides the class-level DSL for declaring that an Active Record model has attached blobs.
   module Attached::Macros

activestorage/lib/active_storage/attached/many.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveStorage
   # Decorated proxy object representing of multiple attachments to a model.
   class Attached::Many < Attached

activestorage/lib/active_storage/attached/one.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveStorage
   # Representation of a single attachment to a model.
   class Attached::One < Attached

activestorage/lib/active_storage/gem_version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveStorage
   # Returns the version of the currently loaded Active Storage as a <tt>Gem::Version</tt>
   def self.gem_version

activestorage/lib/active_storage/log_subscriber.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 require "active_support/log_subscriber"
 
 module ActiveStorage
   class LogSubscriber < ActiveSupport::LogSubscriber
     def service_upload(event)
       message = "Uploaded file to key: #{key_in(event)}"
-      message << " (checksum: #{event.payload[:checksum]})" if event.payload[:checksum]
+      message += " (checksum: #{event.payload[:checksum]})" if event.payload[:checksum]
       info event, color(message, GREEN)
     end
 

activestorage/lib/active_storage/service.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "active_storage/log_subscriber"
 
 module ActiveStorage

activestorage/lib/active_storage/service/azure_storage_service.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "active_support/core_ext/numeric/bytes"
 require "azure/storage"
 require "azure/storage/core/auth/shared_access_signature"

activestorage/lib/active_storage/service/configurator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveStorage
   class Service::Configurator #:nodoc:
     attr_reader :configurations

activestorage/lib/active_storage/service/disk_service.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "fileutils"
 require "pathname"
 require "digest/md5"

activestorage/lib/active_storage/service/gcs_service.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "google/cloud/storage"
 require "active_support/core_ext/object/to_query"
 

activestorage/lib/active_storage/service/mirror_service.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "active_support/core_ext/module/delegation"
 
 module ActiveStorage

activestorage/lib/active_storage/service/s3_service.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "aws-sdk"
 require "active_support/core_ext/numeric/bytes"
 

activestorage/lib/active_storage/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative "gem_version"
 
 module ActiveStorage

activestorage/lib/tasks/activestorage.rake

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 namespace :activestorage do
   desc "Copy over the migration needed to the application"
   task install: :environment do

activestorage/test/controllers/blobs_controller_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "test_helper"
 require "database/setup"
 

activestorage/test/controllers/direct_uploads_controller_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "test_helper"
 require "database/setup"
 

activestorage/test/controllers/disk_controller_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "test_helper"
 require "database/setup"
 

activestorage/test/controllers/variants_controller_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "test_helper"
 require "database/setup"
 

activestorage/test/database/create_users_migration.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ActiveStorageCreateUsers < ActiveRecord::Migration[5.1]
   def change
     create_table :users do |t|

activestorage/test/database/setup.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative "create_users_migration"
 
 ActiveRecord::Base.establish_connection(adapter: "sqlite3", database: ":memory:")

activestorage/test/dummy/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative "config/application"
 
 Rails.application.load_tasks

activestorage/test/dummy/app/controllers/application_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ApplicationController < ActionController::Base
   protect_from_forgery with: :exception
 end

activestorage/test/dummy/app/helpers/application_helper.rb

@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 module ApplicationHelper
 end

activestorage/test/dummy/app/jobs/application_job.rb

@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 class ApplicationJob < ActiveJob::Base
 end

activestorage/test/dummy/app/models/application_record.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ApplicationRecord < ActiveRecord::Base
   self.abstract_class = true
 end

activestorage/test/dummy/bin/bundle

@@ -1,3 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
+
 ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile", __FILE__)
 load Gem.bin_path("bundler", "bundle")

activestorage/test/dummy/bin/rails

@@ -1,4 +1,6 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
+
 APP_PATH = File.expand_path("../config/application", __dir__)
 require_relative "../config/boot"
 require "rails/commands"

activestorage/test/dummy/bin/rake

@@ -1,4 +1,6 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
+
 require_relative "../config/boot"
 require "rake"
 Rake.application.run

activestorage/test/dummy/bin/yarn

@@ -1,4 +1,6 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
+
 VENDOR_PATH = File.expand_path("..", __dir__)
 Dir.chdir(VENDOR_PATH) do
   begin

activestorage/test/dummy/config.ru

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # This file is used by Rack-based servers to start the application.
 
 require_relative "config/environment"

activestorage/test/dummy/config/application.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative "boot"
 
 require "rails"

activestorage/test/dummy/config/boot.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Set up gems listed in the Gemfile.
 ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../../Gemfile", __dir__)
 

activestorage/test/dummy/config/environment.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Load the Rails application.
 require_relative "application"
 

activestorage/test/dummy/config/environments/development.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Rails.application.configure do
   # Settings specified here will take precedence over those in config/application.rb.
 

activestorage/test/dummy/config/environments/production.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Rails.application.configure do
   # Settings specified here will take precedence over those in config/application.rb.
 

activestorage/test/dummy/config/environments/test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Rails.application.configure do
   # Settings specified here will take precedence over those in config/application.rb.
 

activestorage/test/dummy/config/initializers/application_controller_renderer.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Be sure to restart your server when you modify this file.
 
 # ApplicationController.renderer.defaults.merge!(

activestorage/test/dummy/config/initializers/assets.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Version of your assets, change this if you want to expire all your assets.

activestorage/test/dummy/config/initializers/backtrace_silencers.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Be sure to restart your server when you modify this file.
 
 # You can add backtrace silencers for libraries that you're using but don't wish to see in your backtraces.

activestorage/test/dummy/config/initializers/cookies_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Specify a serializer for the signed and encrypted cookie jars.

activestorage/test/dummy/config/initializers/filter_parameter_logging.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Configure sensitive parameters which will be filtered from the log file.

activestorage/test/dummy/config/initializers/inflections.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Be sure to restart your server when you modify this file.
 
 # Add new inflection rules using the following format. Inflections

activestorage/test/dummy/config/initializers/mime_types.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Be sure to restart your server when you modify this file.
 
 # Add new mime types for use in respond_to blocks:

activestorage/test/dummy/config/initializers/wrap_parameters.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # This file contains settings for ActionController::ParamsWrapper which

activestorage/test/dummy/config/routes.rb

@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 Rails.application.routes.draw do
 end

activestorage/test/dummy/config/spring.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 %w(
   .ruby-version
   .rbenv-vars

activestorage/test/filename_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "test_helper"
 
 class ActiveStorage::FilenameTest < ActiveSupport::TestCase
@@ -10,8 +12,8 @@ class ActiveStorage::FilenameTest < ActiveSupport::TestCase
   end
 
   test "sanitize transcodes to valid UTF-8" do
-    { "\xF6".force_encoding(Encoding::ISO8859_1) => "ö",
-      "\xC3".force_encoding(Encoding::ISO8859_1) => "Ã",
+    { "\xF6".dup.force_encoding(Encoding::ISO8859_1) => "ö",
+      "\xC3".dup.force_encoding(Encoding::ISO8859_1) => "Ã",
       "\xAD" => "�",
       "\xCF" => "�",
       "\x00" => "",