remove FrameTiming named constructor (flutter#20380)

jlahd · Aug 10, 2020 · 8b72bbc · 8b72bbc
1 parent 9bc3fe9
commit 8b72bbc
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 48 deletions.
diff --git a/lib/ui/window.dart b/lib/ui/window.dart
@@ -117,30 +117,6 @@ class FrameTiming {
   FrameTiming._(List<int> timestamps)
       : assert(timestamps.length == FramePhase.values.length), _timestamps = timestamps;
 
-  /// Construct [FrameTiming] with given timestamp in micrseconds.
-  ///
-  /// This constructor is used for unit test only. Real [FrameTiming]s should
-  /// be retrieved from [Window.onReportTimings].
-  ///
-  /// TODO(CareF): This is part of #20229. Remove back to default constructor
-  /// after #20229 lands and corresponding framwork PRs land.
-  factory FrameTiming.fromTimeStamps({
-    int? vsyncStart,
-    required int buildStart,
-    required int buildFinish,
-    required int rasterStart,
-    required int rasterFinish
-  }) {
-    return FrameTiming._(<int>[
-      // This is for temporarily backward compatiblilty.
-      vsyncStart ?? buildStart,
-      buildStart,
-      buildFinish,
-      rasterStart,
-      rasterFinish
-    ]);
-  }
-
   /// This is a raw timestamp in microseconds from some epoch. The epoch in all
   /// [FrameTiming] is the same, but it may not match [DateTime]'s epoch.
   int timestampInMicroseconds(FramePhase phase) => _timestamps[phase.index];

diff --git a/lib/web_ui/lib/src/ui/window.dart b/lib/web_ui/lib/src/ui/window.dart
@@ -1070,30 +1070,6 @@ class FrameTiming {
   FrameTiming._(List<int> timestamps)
       : assert(timestamps.length == FramePhase.values.length), _timestamps = timestamps;
 
-  /// Construct [FrameTiming] with given timestamp in micrseconds.
-  ///
-  /// This constructor is used for unit test only. Real [FrameTiming]s should
-  /// be retrieved from [Window.onReportTimings].
-  ///
-  /// TODO(CareF): This is part of #20229. Remove back to default constructor
-  /// after #20229 lands and corresponding framwork PRs land.
-  factory FrameTiming.fromTimeStamps({
-    int? vsyncStart,
-    required int buildStart,
-    required int buildFinish,
-    required int rasterStart,
-    required int rasterFinish
-  }) {
-    return FrameTiming._(<int>[
-      // This is for temporarily backward compatiblilty.
-      vsyncStart ?? buildStart,
-      buildStart,
-      buildFinish,
-      rasterStart,
-      rasterFinish
-    ]);
-  }
-
   /// This is a raw timestamp in microseconds from some epoch. The epoch in all
   /// [FrameTiming] is the same, but it may not match [DateTime]'s epoch.
   int timestampInMicroseconds(FramePhase phase) => _timestamps[phase.index];