bugfix: use [[:space:]] instead of \s when detecting double/single op…

…ening quotes to account for unicode non-breaking space character (\u00a0)
jmcnevin · Feb 4, 2015 · 4f8ae30 · 4f8ae30
1 parent b017a0b
commit 4f8ae30
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/lib/rubypants/core.rb b/lib/rubypants/core.rb
@@ -270,7 +270,7 @@ def educate_quotes(str)
     dec_dashes = "#{entity(:en_dash)}|#{entity(:em_dash)}"
 
     # Get most opening single quotes:
-    str.gsub!(/(\s|&nbsp;|--|&[mn]dash;|#{dec_dashes}|&#x201[34];)'(?=\w)/,
+    str.gsub!(/([[:space:]]|&nbsp;|--|&[mn]dash;|#{dec_dashes}|&#x201[34];)'(?=\w)/,
              '\1' + entity(:single_left_quote))
 
     # Single closing quotes:
@@ -284,7 +284,7 @@ def educate_quotes(str)
               entity(:single_left_quote))
 
     # Get most opening double quotes:
-    str.gsub!(/(\s|&nbsp;|--|&[mn]dash;|#{dec_dashes}|&#x201[34];)"(?=\w)/,
+    str.gsub!(/([[:space:]]|&nbsp;|--|&[mn]dash;|#{dec_dashes}|&#x201[34];)"(?=\w)/,
              '\1' + entity(:double_left_quote))
 
     # Double closing quotes:

diff --git a/test/rubypants_test.rb b/test/rubypants_test.rb
@@ -62,6 +62,9 @@ def test_quotes
 
     assert_rp_equal '<b>"</b>', "<b>&#8220;</b>"
     assert_rp_equal 'foo<b>"</b>', "foo<b>&#8221;</b>"
+
+    assert_rp_equal "foo\u00a0\"bar\"", "foo\u00a0&#8220;bar&#8221;"
+    assert_rp_equal "foo\u00a0'bar'", "foo\u00a0&#8216;bar&#8217;"
   end
 
   def test_dashes