feat(project): prefix variable environments with CHEWDATA (#60) #229
Annotations
11 warnings
empty line after doc comment:
src/updater/tera_helpers/function/object.rs#L219
warning: empty line after doc comment
--> src/updater/tera_helpers/function/object.rs:219:1
|
219 | / /// let target = serde_json::from_str::<Value>(r#"{"field_1":"value_1","field_2":"value_1"}"#).unwrap();
220 | |
| |_
...
233 | pub fn replace_value(args: &HashMap<String, Value>) -> Result<Value> {
| -------------------------------------------------------------------- the comment documents this function
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
= help: if the empty line is unintentional remove it
help: if the documentation should include the empty line include it in the comment
|
220 | ///
|
|
you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`:
src/updater/tera.rs#L64
warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
--> src/updater/tera.rs:64:13
|
64 | / match &action.pattern {
65 | | Some(pattern) => {
66 | | trace!(
67 | | field = action.field.as_str(),
... |
106 | | None => (),
107 | | };
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
= note: `#[warn(clippy::single_match)]` on by default
help: try
|
64 ~ if let Some(pattern) = &action.pattern {
65 + trace!(
66 + field = action.field.as_str(),
67 + pattern = pattern,
68 + "Field/Pattern that will be apply on the output"
69 + );
70 +
71 + let render_result: String =
72 + match engine.render_str(pattern.as_str(), &tera_context) {
73 + Ok(render_result) => Ok(render_result),
74 + Err(e) => Err(io::Error::new(
75 + io::ErrorKind::InvalidInput,
76 + format!(
77 + "Failed to render the field '{}'. {}.",
78 + action.field,
79 + match e.source() {
80 + Some(e) => {
81 + match e.source() {
82 + Some(e) => e.to_string(),
83 + None => e.to_string(),
84 + }
85 + }
86 + None => format!("Please fix the pattern `{}`", pattern),
87 + }
88 + .replace(" '__tera_one_off'", "")
89 + ),
90 + )),
91 + }?;
92 +
93 + trace!(
94 + value = render_result.display_only_for_debugging(),
95 + "Field value before resolved it"
96 + );
97 +
98 + field_new_value = Value::resolve(render_result);
99 +
100 + trace!(
101 + value = field_new_value.display_only_for_debugging(),
102 + "Field value after resolved it"
103 + );
104 ~ };
|
|
large size difference between variants:
src/document/mod.rs#L34
warning: large size difference between variants
--> src/document/mod.rs:34:1
|
34 | / pub enum DocumentType {
35 | | #[cfg(feature = "csv")]
36 | | #[serde(rename = "csv")]
37 | | Csv(Csv),
... |
44 | | Xml(Xml),
| | -------- the second-largest variant contains at least 320 bytes
... |
58 | | Parquet(Parquet),
| | ---------------- the largest variant contains at least 552 bytes
59 | | }
| |_^ the entire enum is at least 552 bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
= note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
|
58 | Parquet(Box<Parquet>),
| ~~~~~~~~~~~~
|
you seem to be trying to use `&Box<T>`. Consider using just `&T`:
src/connector/mod.rs#L126
warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
--> src/connector/mod.rs:126:34
|
126 | fn document(&self) -> Result<&Box<dyn Document>> {
| ^^^^^^^^^^^^^^^^^^ help: try: `&dyn Document`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
= note: `#[warn(clippy::borrowed_box)]` on by default
|
very complex type used. Consider factoring parts into `type` definitions:
src/connector/psql.rs#L62
warning: very complex type used. Consider factoring parts into `type` definitions
--> src/connector/psql.rs:62:17
|
62 | static CLIENTS: OnceLock<Arc<Mutex<HashMap<String, Pool<Postgres>>>>> = OnceLock::new();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
very complex type used. Consider factoring parts into `type` definitions:
src/connector/local.rs#L64
warning: very complex type used. Consider factoring parts into `type` definitions
--> src/connector/local.rs:64:16
|
64 | static CACHES: OnceLock<Arc<Mutex<HashMap<String, Vec<DataResult>>>>> = OnceLock::new();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
all
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
all
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
all
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
all
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
all
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|