Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy project URL to clipboard on share #1887

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

namoscato
Copy link
Contributor

This at least works in Chrome, but I was not able to test this end-to-end locally due to whitelisted server origins. I'm also up for suggestions on how to better target the <input> element.

@jmoenig
Copy link
Owner

jmoenig commented Jan 3, 2018

very interesting, thank you! Let me have a closer look at this...

@brianharvey
Copy link
Collaborator

If I'm understanding what this is trying to do, I'm against it; I don't like software to make decisions about my clipboard so I'm surprised when something doesn't work. It's not very hard to click on the URL bar and then click copy.

@namoscato
Copy link
Contributor Author

@brianharvey, fair point.

I use Snap! to teach an Introduction to Computer Science course though, and surprisingly, it was difficult for some of the students to copy the URL from the browser's address bar. Project submission is dependent on sharing at the moment, and I was looking to optimize this flow. This seemed liked the quickest path, but do you have any thoughts on an alternative UX?

@brianharvey
Copy link
Collaborator

Groan. I suppose it could be a configurable option... if Jens will allow another one in the settings menu.

@cycomachead
Copy link
Collaborator

We do have an alternate UX. Namely a #1084 -- though we could extend that to always show the URL dialog when you click "Share" even before you click "open".

@jguille2
Copy link
Contributor

jguille2 commented Mar 9, 2018

Hi @cycomachead ,

I only point out that this PR is from 2015... and of course it would need different adaptations (especially the changes in the cloud functions).

Anyway, you know this feature was added in Snap4Arduino, so you can find there an updated proposal.

You can test it in Snap4Arduino online.
[Note you also will find an "strange" Open from URL... option... but required for our desktop version (without url bar))

Joan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants