Change octaves in piano keyboard

[ego-lay-atman-bay]

I added the ability to change octaves in the piano keyboard.

I did also make sure to take into account the (computer) keyboard support.

I kept the ability to use the arrow keys to change notes (and it goes through all the octaves when the selected key reaches the edge of the keyboard). If you hold shift while pressing an arrow key, it changes the octave.

The letter key shortcuts are also usable (which selects the key in the current octave).

This addition is great, because it allows a selection of the full midi range, not just 2 octaves. It's better for users creating music, and not forcing the user to guess the correct midi number.

[jmoenig]

Awesome, @ego-lay-atman-bay , thank you so much! And it comes just in time for v10 :)

[edit] I love this kind of PR that adds an almost invisible but madly useful feature.

[jmoenig]

BTW, If you send me a message or email with your real name I'll add an entry in the credits dialog and I'll also credit you in the sources. If you prefer to keep it private I'll mention your Github handle.

[ego-lay-atman-bay]

I prefer to keep my real name private, so my username would be prefered.

[jmoenig]

Excellent, will do. Thank you, great job!

[jmoenig]

I've integrated your pull request, and tweaked a few minor details: 370a359c3aa2786b8c87bf903d83dd0ddfb06d5c

Just some little stuff JSHint complained about. Also the direction when holding down the left/right arrow keys seemed to be reversed, and two methods apparently didn't ever get called, so I took them out.

If you get a chance to look over these tweaks please let me know if I misunderstood anything. I'll create another release candidate now, later today I'll release v10 with whatever we have.

Again, thank you!

[jmoenig]

it's now also online in rc6, if you'd like to give it a try

[ego-lay-atman-bay]

The 2 methods you removed (selextUp and selectDown) were used, until you replaced

if (event.shiftKey) {
    return this.octaveUp();
} else {
    return this.selectUp();
}

with

return event.shiftKey ?
this.octaveDown()
: this.octaveUp();

(same with the down arrow key)

This results in changing the octave whenever you press the arrow key, and you can't change the note with the arrow keys (that's what the selectUp and selectDown functions are used for).

The arrow keys were not reversed, I know for certain, because I tested then out many many times.

If you press the left/down arrow key, the note goes down. If you hold shift, the octave goes down.
If you press the right/up arrow key, the note goes up. If you hold shift, the octave goes up.

[jmoenig]

Ah, so is the current behavior now wrong?

[ego-lay-atman-bay]

Yes, it now behaves like this.

If you press the left/down key, the octave goes down. If you hold shift, the octave goes up.
If you press the right/up arrow key, the octave goes up. If you hold shift, the octave goes down.

[jmoenig]

Yep, that's what I thought should happen. What did you want to happen?

[ego-lay-atman-bay]

If you press the left/down arrow key, the note goes down. If you hold shift, the octave goes down.
If you press the right/up arrow key, the note goes up. If you hold shift, the octave goes up.

The note changing was a feature of the old piano keyboard, which I want to keep, that's why I made octave switching be done by holding shift. It's much more intuitive for people using the arrow keys to move notes, and not have to rely on pressing the right letter key.

[jmoenig]

Ah, okay, so let me revert those changes ... in a minute (I'm busy with something else right now). Thanks!

[jmoenig]

I've reverted to your original behavior: 99a4890
and made another release candidate. If you find the time can you confirm that this is now how you intended it to work?
Thanks!

[ego-lay-atman-bay]

That looks right, thanks!

[jmoenig]

Thank you for the quick test & confirmation, and for this beautiful feature!