Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor "song" to "track" in the entire app. #1059

Merged
merged 5 commits into from
Mar 3, 2025

Conversation

lukaslindnermusic
Copy link

Exception: /lib/services/jellyfin_api.dart

I hope everything is working properly.
I tested the app briefly, and everything seemed to function as before, but I might have overlooked something.

I wasn’t sure what to do with the other language .arb files. Since the Polish file was causing my builds to fail, I deleted all language files except app_en.arb on my local branch.

How do the translations work? Do I have to edit the other language files (more specifically the keys) manually as well?

If the syntax errors in the Polish file are due to an issue with my local encoding or something similar, I’d be happy to get some help resolving it (I am new to Dart, Flutter and also Visual Studio Code and working with git repos... only did web programming before). 😊

Exception: /lib/services/jellyfin_api.dart
@lukaslindnermusic
Copy link
Author

Discussed in this issue: #675

@Chaphasilor
Copy link
Collaborator

Thanks! I've been looking forward to this :D

Regarding the translations, if you delete the files and we merge the PR, all translations would be deleted. So you should redo the deletion. The easiest way to do that is probably to switch to the redesign branch (where I've fixed the syntax error causing the build issues), and then copy all the translation file into a temporary folder, before switching back into your branch. There you can add the files back where they belong, and re-do the renaming afterwards.
If you're unsure how to do that, I can also handle it for you :)

@lukaslindnermusic
Copy link
Author

4ef762c also includes the rollback of trackCount -> songCount.

Also, I noticed, that the german translations sometimes are really weird and fixed a lot of translations, as this is my main language. (I hope it is okay that I did this directly within this pull request?)

@Chaphasilor Chaphasilor merged commit 50afb6f into jmshrv:redesign Mar 3, 2025
4 checks passed
@Chaphasilor
Copy link
Collaborator

Thanks for refactoring this! I'm sure we'll end up with a few mentions of "songs" again after a while, but those should be easily fixable 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants