small refactor

jodoglevy · Sep 3, 2012 · 2e62b97 · 2e62b97
1 parent 3eb629f
commit 2e62b97
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/chrome/redirect.js b/chrome/redirect.js
@@ -77,7 +77,10 @@ function addStoryTitlesToFBAppURLs() {
 }
 
 function checkForOpenGraphOAuth() {
-    var isLooping = localStorage.getItem("lastFBPageAccessed") == document.URL;  
+    var lastFBPageAccessedString = "lastFBPageAccessed";
+
+    var isLooping = localStorage.getItem(lastFBPageAccessedString) == document.URL;  
+    localStorage.setItem(lastFBPageAccessedString, document.URL);  
 
     if(document.URL.indexOf("dialog/oauth") !== -1 || document.URL.indexOf("connect/uiserver") !== -1) {
         var redirectURI = getURLParameterByName( document.URL, "redirect_uri");
@@ -89,8 +92,6 @@ function checkForOpenGraphOAuth() {
             else if(redirectTitle) window.location = "https://www.google.com/search?btnI&q=" + unescape(redirectTitle);
         }
     }
-
-    localStorage.setItem("lastFBPageAccessed", document.URL);  
 }
 
 

diff --git a/firefox/data/redirect.js b/firefox/data/redirect.js
@@ -77,7 +77,10 @@ function addStoryTitlesToFBAppURLs() {
 }
 
 function checkForOpenGraphOAuth() {
-    var isLooping = localStorage.getItem("lastFBPageAccessed") == document.URL;  
+    var lastFBPageAccessedString = "lastFBPageAccessed";
+
+    var isLooping = localStorage.getItem(lastFBPageAccessedString) == document.URL;  
+    localStorage.setItem(lastFBPageAccessedString, document.URL);  
 
     if(document.URL.indexOf("dialog/oauth") !== -1 || document.URL.indexOf("connect/uiserver") !== -1) {
         var redirectURI = getURLParameterByName( document.URL, "redirect_uri");
@@ -89,8 +92,6 @@ function checkForOpenGraphOAuth() {
             else if(redirectTitle) window.location = "https://www.google.com/search?btnI&q=" + unescape(redirectTitle);
         }
     }
-
-    localStorage.setItem("lastFBPageAccessed", document.URL);  
 }
 
 

diff --git a/firefox/package.json b/firefox/package.json
@@ -6,5 +6,5 @@
   "contributors": "Joe Levy",
   "license": "MPL 1.1/GPL 2.0/LGPL 2.1",
   "id": "[email protected]",
-  "version": "1.7"
+  "version": "1.8"
 }