conditionally add annotations key #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-elliott
reviewed
Jan 2, 2025
| @@ -19,8 +19,10 @@ spec: | |||
| {{- with .Values.certManager.additionalPodLabels }} | |||
| {{- toYaml . | nindent 8 }} | |||
| {{- end }} | |||
| {{- if .Values.certManager.podAnnotations }} | |||
There was a problem hiding this comment.
It's not currently broken. However, GitOps tools will detect differences when K8s adds annotations like restartAt.... In contrast, I do not see any value in rendering empty as default.
What do you think?
There was a problem hiding this comment.
Maybe this diff helps to clarify my previous comments.
When AroCD syncs the application, it will detect changes because of explicit empty annotations in helm render.
# Source: cert-exporter/charts/cert-exporter/templates/cert-m # Source: cert-exporter/charts/cert-exporter/templates/cert-m
apiVersion: apps/v1 apiVersion: apps/v1
kind: DaemonSet kind: DaemonSet
metadata: metadata:
name: "cert-exporter-cert-manager" name: "cert-exporter-cert-manager"
labels: labels:
helm.sh/chart: cert-exporter-3.9.0 | helm.sh/chart: cert-exporter-3.10.0
app.kubernetes.io/name: cert-exporter app.kubernetes.io/name: cert-exporter
app.kubernetes.io/instance: cert-exporter app.kubernetes.io/instance: cert-exporter
cert-exporter.io/type: daemon-set cert-exporter.io/type: daemon-set
app.kubernetes.io/version: "v2.14.0" app.kubernetes.io/version: "v2.14.0"
app.kubernetes.io/managed-by: Helm app.kubernetes.io/managed-by: Helm
spec: spec:
selector: selector:
matchLabels: matchLabels:
app.kubernetes.io/name: cert-exporter app.kubernetes.io/name: cert-exporter
app.kubernetes.io/instance: cert-exporter app.kubernetes.io/instance: cert-exporter
cert-exporter.io/type: daemon-set cert-exporter.io/type: daemon-set
template: template:
metadata: metadata:
labels: labels:
app.kubernetes.io/name: cert-exporter app.kubernetes.io/name: cert-exporter
app.kubernetes.io/instance: cert-exporter app.kubernetes.io/instance: cert-exporter
cert-exporter.io/type: daemon-set cert-exporter.io/type: daemon-set
annotations: <
{} <
spec: spec:
serviceAccountName: cert-exporter serviceAccountName: cert-exporter
There was a problem hiding this comment.
ah, i see
glad to remove this. thank you for the improvement! 🙏
joe-elliott
approved these changes
Jan 3, 2025
| @@ -19,8 +19,10 @@ spec: | |||
| {{- with .Values.certManager.additionalPodLabels }} | |||
| {{- toYaml . | nindent 8 }} | |||
| {{- end }} | |||
| {{- if .Values.certManager.podAnnotations }} | |||
There was a problem hiding this comment.
ah, i see
glad to remove this. thank you for the improvement! 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While deploying with ArgoCD, I faced and issue where application is out of sync after daemonset restart.
This is because helm render "forces" empty annotations.
