Unmapping after execution, extra tests and the GuardedSignalCommandMap #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… behaviour ambiguities). Tests to SignalCommandMap intended to clarify the injector behaviour when a value has not been dispatched by this signal but has been dispatched by a previous signal.
…h SignalCommandMap
… the command is executed. GuardedSignalCommandMap completed - all tests passing.
|
Is it even possible to notify all the forks? I make no warranty! |
|
True :) Buyer-beware-stocks-may-go-down-as-well-as-up yada yada. I'll blog it as well - it's interesting fodder about how tricky it is to trap corner cases as well. Always useful but difficult to test what your code doesn't do as well as what it does. The 'doesn't' being one of those autistic-people-can't-think-about-it questions. Like... what I didn't have for breakfast. A hippopotamus... and then the list is endless. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happy to split the Guarded map off into a separate repo, but the underlying changes in SCM are needed anyway.
Let me know if you want to keep it as 2 separate projects (I was going to but Neil Manuell had already done his work in a pull from this fork).
I guess we need to inform other forks of the potential problem?
Stray