feat: improve language error handling and adjust test

johannesjo · Jan 10, 2025 · 4a50cb3 · 4a50cb3
1 parent 06bbedf
commit 4a50cb3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/e2e/commands/noError.ts b/e2e/commands/noError.ts
@@ -6,7 +6,9 @@ module.exports = {
       browser.getLog('browser', (logEntries) => {
         const errors = logEntries.filter((entry) => entry.level.name === 'SEVERE');
         if (errors.length > 0) {
+          console.log('\nBROWSER CONSOLE ERRORS:');
           console.error(errors);
+          console.log('\n');
         }
         browser.assert.equal(errors.length, 0, 'No console errors found');
       }),

diff --git a/src/app/core/language/language.service.ts b/src/app/core/language/language.service.ts
@@ -34,7 +34,11 @@ export class LanguageService {
     if (lng && Object.values(LanguageCode).includes(lng)) {
       this._setFn(lng);
     } else {
-      console.error('Invalid language code', lng);
+      if (lng) {
+        console.error('Invalid language code', lng);
+      } else {
+        console.warn('No language code provided');
+      }
       this.setFromBrowserLngIfAutoSwitchLng();
     }
   }