Skip to content

Testing workflow #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Jul 18, 2024
Merged

Testing workflow #2

merged 31 commits into from
Jul 18, 2024

Conversation

john0isaac
Copy link
Owner

Purpose

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.

[ ] Yes
[ ] No

Type of change

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

  • The current tests all pass (python -m pytest).
  • I added tests that prove my fix is effective or that my feature works
  • I ran python -m pytest --cov to verify 100% coverage of added lines
  • I ran python -m mypy to check for type errors
  • I either used the pre-commit hooks or ran ruff manually on my code.

john0isaac and others added 30 commits June 28, 2024 19:52
psycopg2-binary is required by create_engine for postgresql database in setting up the tests
There is no need to do a full installation to use ruff this will make the workflow faster
this also improves the swagger api examples as it's typed now
there is only one engine, sessionmaker, azure_credentials, context, chat_client, and embed_client created during the lifespan of the fastapi app
AsyncTokenCredentials is not the correct class to inherit from as we are not using the async credentials
@john0isaac john0isaac merged commit 3c3d0d1 into main Jul 18, 2024
10 of 12 checks passed
@john0isaac john0isaac deleted the improve-and-tests branch July 18, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants