Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Pascal Birchler <[email protected]>
  • Loading branch information
BrianHenryIE and swissspidy authored May 23, 2024
1 parent c04d674 commit a970cd4
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions tests/test-file-cache.php
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,8 @@ public function test_import() {
$result = $cache->import( $key, $fixture_filepath );

// Assert file is imported.
self::assertTrue( $result );
self::assertFileExists( "{$cache_dir}/{$key}" );
$this->assertTrue( $result );
$this->assertFileExists( "{$cache_dir}/{$key}" );

// Clean up.
$cache->clear();
Expand Down Expand Up @@ -167,8 +167,8 @@ function ( $errno, $errstr ) use ( &$error ) {

restore_error_handler();

self::assertNull( $error );
self::assertFalse( $result );
$this->assertNull( $error );
$this->assertFalse( $result );

// Clean up.
$cache->clear();
Expand Down Expand Up @@ -199,7 +199,7 @@ public function test_validate_key_ending_in_period() {

$result = $method->invoke( $cache, $key );

self::assertFalse( str_ends_with( $result, '.' ) );
self::assertEquals( 'plugin/advanced-sidebar-menu-pro-9.5.7', $result );
$this->assertStringEndsNotWith( '.', $result );
$this->assertSame( 'plugin/advanced-sidebar-menu-pro-9.5.7', $result );
}
}

0 comments on commit a970cd4

Please sign in to comment.