Skip to content

Commit

Permalink
app-emulation/wine-staging: filter lto and no-plt directly
Browse files Browse the repository at this point in the history
These are semi-popular and no reason to allow something that
fails to build even with USE=custom-cflags (that's more aimed
at runtime fragility than build failures here).

Could imagine -flto or maybe even -fno-plt being "potentially"
whitelisted by strip-flags as it gain more support too.

Note -fno-plt is only an issue with USE=-mingw.

Signed-off-by: Ionen Wolkens <[email protected]>
  • Loading branch information
ionenwks committed Dec 6, 2022
1 parent c6a29ec commit 06360f1
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 10 deletions.
6 changes: 4 additions & 2 deletions app-emulation/wine-staging/wine-staging-7.19.ebuild
Original file line number Diff line number Diff line change
Expand Up @@ -246,8 +246,10 @@ src_configure() {
$(usev !odbc ac_cv_lib_soname_odbc=)
)

tc-ld-force-bfd #867097
use custom-cflags || strip-flags # can break in obscure ways, also no lto
tc-ld-force-bfd # builds with non-bfd but broken at runtime (bug #867097)
filter-lto # build failure
use mingw || filter-flags -fno-plt # build failure
use custom-cflags || strip-flags # can break in obscure ways at runtime
use crossdev-mingw || PATH=${BROOT}/usr/lib/mingw64-toolchain/bin:${PATH}

# temporary workaround for tc-ld-force-bfd not yet enforcing with mold
Expand Down
6 changes: 4 additions & 2 deletions app-emulation/wine-staging/wine-staging-7.20.ebuild
Original file line number Diff line number Diff line change
Expand Up @@ -246,8 +246,10 @@ src_configure() {
$(usev !odbc ac_cv_lib_soname_odbc=)
)

tc-ld-force-bfd #867097
use custom-cflags || strip-flags # can break in obscure ways, also no lto
tc-ld-force-bfd # builds with non-bfd but broken at runtime (bug #867097)
filter-lto # build failure
use mingw || filter-flags -fno-plt # build failure
use custom-cflags || strip-flags # can break in obscure ways at runtime
use crossdev-mingw || PATH=${BROOT}/usr/lib/mingw64-toolchain/bin:${PATH}

# temporary workaround for tc-ld-force-bfd not yet enforcing with mold
Expand Down
6 changes: 4 additions & 2 deletions app-emulation/wine-staging/wine-staging-7.21-r1.ebuild
Original file line number Diff line number Diff line change
Expand Up @@ -248,8 +248,10 @@ src_configure() {
$(usev !odbc ac_cv_lib_soname_odbc=)
)

tc-ld-force-bfd #867097
use custom-cflags || strip-flags # can break in obscure ways, also no lto
tc-ld-force-bfd # builds with non-bfd but broken at runtime (bug #867097)
filter-lto # build failure
use mingw || filter-flags -fno-plt # build failure
use custom-cflags || strip-flags # can break in obscure ways at runtime
use crossdev-mingw || PATH=${BROOT}/usr/lib/mingw64-toolchain/bin:${PATH}

# temporary workaround for tc-ld-force-bfd not yet enforcing with mold
Expand Down
6 changes: 4 additions & 2 deletions app-emulation/wine-staging/wine-staging-7.22.ebuild
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,10 @@ src_configure() {
$(usev !odbc ac_cv_lib_soname_odbc=)
)

tc-ld-force-bfd #867097
use custom-cflags || strip-flags # can break in obscure ways, also no lto
tc-ld-force-bfd # builds with non-bfd but broken at runtime (bug #867097)
filter-lto # build failure
use mingw || filter-flags -fno-plt # build failure
use custom-cflags || strip-flags # can break in obscure ways at runtime
use crossdev-mingw || PATH=${BROOT}/usr/lib/mingw64-toolchain/bin:${PATH}

# temporary workaround for tc-ld-force-bfd not yet enforcing with mold
Expand Down
6 changes: 4 additions & 2 deletions app-emulation/wine-staging/wine-staging-9999.ebuild
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,10 @@ src_configure() {
$(usev !odbc ac_cv_lib_soname_odbc=)
)

tc-ld-force-bfd #867097
use custom-cflags || strip-flags # can break in obscure ways, also no lto
tc-ld-force-bfd # builds with non-bfd but broken at runtime (bug #867097)
filter-lto # build failure
use mingw || filter-flags -fno-plt # build failure
use custom-cflags || strip-flags # can break in obscure ways at runtime
use crossdev-mingw || PATH=${BROOT}/usr/lib/mingw64-toolchain/bin:${PATH}

# temporary workaround for tc-ld-force-bfd not yet enforcing with mold
Expand Down

0 comments on commit 06360f1

Please sign in to comment.