Skip to content

Commit

Permalink
Revert "dev-ml/lablgl: Remove another := slot op from || dep"
Browse files Browse the repository at this point in the history
This reverts commit 9675d96.

This commit is wrong in several aspects:
  - Such changes should come with a revbump
  - Removing := deps causes packages not to be rebuilt on upgrades, causing
    barely understandable build failures when upgrading, later on.
    Thanks to this commit, people that have installed those packages will
    likely experience those failures with the upcoming ocaml 4.03 unmask.
  - This is a non maintainer commit where no discussion at all happened with the
    maintainers during the 3 days between bug report and mass commit.
    Such discussion could have prevented the above mentioned breakage.

Proper fix is to drop the backward compatibility part of the || () dep. This fix
was slowly moving forward whenever possible and noticed. Main blocker for this is
bug #463018 which requires taking extra care for not breaking the stable tree
nor needlessly preventing future stabilization of packages.
  • Loading branch information
aballier committed Jun 23, 2016
1 parent 0129041 commit 1d90270
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion dev-ml/lablgl/lablgl-1.05.ebuild
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ RDEPEND="
tk? (
>=dev-lang/tcl-8.3:0=
>=dev-lang/tk-8.3:0=
|| ( dev-ml/labltk <dev-lang/ocaml-4.02[tk] )
|| ( dev-ml/labltk:= <dev-lang/ocaml-4.02[tk] )
)
"

Expand Down

0 comments on commit 1d90270

Please sign in to comment.