Skip to content

Commit

Permalink
games-strategy/naev-0.7.0: fix SRC_URI, explain BDEPEND/src_unpack
Browse files Browse the repository at this point in the history
pkgcheck complains about the lack of app-arch/unzip in BDEPEND but
that is not correct - the data file is supposed to be installed zipped,
and the custom src_unpack ensures only the source tarball is actually
unpacked. Add a comment explaining this.

More importantly, both SRC_URI wrong had '/${P}/' where '/v${PV}/' should
be according to the layout of GitHub upstream as of 5 minutes ago.

Signed-off-by: Marek Szuba <[email protected]>
  • Loading branch information
Marek Szuba committed Dec 1, 2020
1 parent c9f8ba0 commit 2e18346
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions games-strategy/naev/naev-0.7.0.ebuild
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,13 @@
# Distributed under the terms of the GNU General Public License v2

EAPI=7

inherit xdg-utils

DESCRIPTION="A 2D space trading and combat game, in a similar vein to Escape Velocity"
HOMEPAGE="https://naev.org/ https://github.com/naev/naev"
SRC_URI="https://github.com/naev/naev/releases/download/${P}/${P}.tar.bz2
https://github.com/naev/naev/releases/download/${P}/${P}-ndata.zip"
SRC_URI="https://github.com/naev/naev/releases/download/v${PV}/${P}.tar.bz2
https://github.com/naev/naev/releases/download/v${PV}/${P}-ndata.zip"

LICENSE="GPL-2 GPL-3 public-domain CC-BY-3.0 CC-BY-SA-3.0"
SLOT="0"
Expand All @@ -30,6 +31,9 @@ RDEPEND="
DEPEND="${RDEPEND}"
BDEPEND="virtual/pkgconfig"

# This is so that only the source tarball is unpacked - the data file
# is supposed to be installed *zipped*. This is why we do not need unzip
# in BDEPEND in spite of what repoman/pkgcheck might say.
src_unpack() {
unpack ${P}.tar.bz2
}
Expand Down

0 comments on commit 2e18346

Please sign in to comment.