Skip to content

Commit

Permalink
www-client/chromium: check tc-ld-is-lld for use_lld param
Browse files Browse the repository at this point in the history
Make sure we enable the LLD toggle if the user has enabled LLD themselves
rather than the ebuild doing it.

Signed-off-by: Sam James <[email protected]>
  • Loading branch information
thesamesam committed Jan 28, 2024
1 parent 41b7f20 commit 388df07
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion www-client/chromium/chromium-120.0.6099.129.ebuild
Original file line number Diff line number Diff line change
Expand Up @@ -723,7 +723,7 @@ chromium_configure() {
append-ldflags $(test-flags-CCLD -Wl,--undefined-version)

# Force lld for lto and pgo builds, otherwise disable, bug 641556
if needs_lld || use lto || use pgo; then
if needs_lld || tc-ld-is-lld || use lto || use pgo; then
myconf_gn+=" use_lld=true"
else
myconf_gn+=" use_lld=false"
Expand Down
2 changes: 1 addition & 1 deletion www-client/chromium/chromium-120.0.6099.224.ebuild
Original file line number Diff line number Diff line change
Expand Up @@ -723,7 +723,7 @@ chromium_configure() {
append-ldflags $(test-flags-CCLD -Wl,--undefined-version)

# Force lld for lto and pgo builds, otherwise disable, bug 641556
if needs_lld || use lto || use pgo; then
if needs_lld || tc-ld-is-lld || use lto || use pgo; then
myconf_gn+=" use_lld=true"
else
myconf_gn+=" use_lld=false"
Expand Down
2 changes: 1 addition & 1 deletion www-client/chromium/chromium-121.0.6167.85.ebuild
Original file line number Diff line number Diff line change
Expand Up @@ -764,7 +764,7 @@ chromium_configure() {
append-ldflags $(test-flags-CCLD -Wl,--undefined-version)

# 641556: Force lld for lto and pgo builds, otherwise disable
if needs_lld || use lto || use pgo; then
if needs_lld || tc-ld-is-lld || use lto || use pgo; then
myconf_gn+=" use_lld=true"
else
# This doesn't prevent lld from being used, but rather prevents gn from forcing it
Expand Down
2 changes: 1 addition & 1 deletion www-client/chromium/chromium-122.0.6261.6.ebuild
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ needs_clang() {
needs_lld() {
# #641556: Force lld for lto and pgo builds, otherwise disable
# #918897: Temporary hack w/ use arm64
[[ ${CHROMIUM_FORCE_LLD} == yes ]] || use lto || use pgo || use arm64
[[ ${CHROMIUM_FORCE_LLD} == yes ]] || tc-ld-is-lld || use lto || use pgo || use arm64
}

llvm_check_deps() {
Expand Down

0 comments on commit 388df07

Please sign in to comment.