Skip to content

Commit

Permalink
dev-util/android-studio: keep jre symlink but use JAVA_HOME first
Browse files Browse the repository at this point in the history
Closes: https://bugs.gentoo.org/660404
Package-Manager: Portage-2.3.40, Repoman-2.3.9
  • Loading branch information
perfinion committed Jul 20, 2018
1 parent 5d15f4e commit 50b76a4
Show file tree
Hide file tree
Showing 2 changed files with 44 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,14 @@ RDEPEND=">=virtual/jdk-1.7
>=x11-libs/libxcb-1.9.1
>=x11-libs/libxshmfence-1.1"
S=${WORKDIR}/${PN}
PATCHES=( "${FILESDIR}/0001-use-java-home-before-bundled.patch" )

src_prepare() {
eapply "${PATCHES[@]}"
eapply_user

# This is really a bundled jdk not a jre
rm -R "${S}/jre" || die "Could not remove bundled jdk"
rm -rf "${S}/jre" || die "Could not remove bundled jdk"

# Replace bundled jars with system
# has problems with newer jdom:0 not updated to jdom:2
Expand Down Expand Up @@ -98,6 +101,7 @@ src_install() {
doins -r *

rm -rf "${D}${dir}/jre" || die
dosym "../../etc/java-config-2/current-system-vm" "${dir}/jre"

fperms 755 "${dir}/bin/studio.sh" "${dir}"/bin/fsnotifier{,64}
chmod 755 "${D}${dir}"/gradle/gradle-*/bin/gradle || die
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
Use JAVA_HOME before bundled jre

Must keep bundled jre symlink around in case "Use Embedded JDK" is selected

https://bugs.gentoo.org/613868
https://bugs.gentoo.org/660404

--- android-studio/bin/studio.sh 2018-07-20 13:43:12.339049033 +0800
+++ android-studio/bin/studio.sh 2018-07-20 13:43:38.494932028 +0800
@@ -73,6 +73,14 @@
fi
fi

+if [ -z "$JDK" -a -n "$JDK_HOME" -a -x "$JDK_HOME/bin/java" ]; then
+ JDK="$JDK_HOME"
+fi
+
+if [ -z "$JDK" -a -n "$JAVA_HOME" -a -x "$JAVA_HOME/bin/java" ]; then
+ JDK="$JAVA_HOME"
+fi
+
if [ -z "$JDK" -a "$OS_TYPE" = "Linux" ] ; then
BUNDLED_JRE="$IDE_HOME/jre64"
if [ ! -d "$BUNDLED_JRE" ]; then
@@ -83,14 +91,6 @@
fi
fi

-if [ -z "$JDK" -a -n "$JDK_HOME" -a -x "$JDK_HOME/bin/java" ]; then
- JDK="$JDK_HOME"
-fi
-
-if [ -z "$JDK" -a -n "$JAVA_HOME" -a -x "$JAVA_HOME/bin/java" ]; then
- JDK="$JAVA_HOME"
-fi
-
if [ -z "$JDK" ]; then
JDK_PATH=`which java`

0 comments on commit 50b76a4

Please sign in to comment.