Skip to content

Commit

Permalink
app-portage/layman: Bump with patch, fixes bug 582154
Browse files Browse the repository at this point in the history
Package-Manager: portage-2.3.0_rc1
  • Loading branch information
dol-sen committed May 31, 2016
1 parent 107c919 commit 70376e2
Show file tree
Hide file tree
Showing 2 changed files with 46 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
From 90fe6724d0a8d1ebfe6443dee118432e20432b8b Mon Sep 17 00:00:00 2001
From: Brian Dolbec <[email protected]>
Date: Tue, 10 May 2016 15:12:02 -0700
Subject: [PATCH] layman/module.py: Fix commit 63808ef00f94 mis-applied
'sourcefile' attribute changes

It was not looking for the 'sourcefile' attribute first, then falling back to the kidname for
backward compatibility.
It was incorrectly looking for an ImportError, instead of a 'sourcefile' KeyError.
The filepath of the affected file for the error message had an extra leading '_'.
Add the module name to the warning message.
---
layman/module.py | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/layman/module.py b/layman/module.py
index 08bcbc2..092418f 100644
--- a/layman/module.py
+++ b/layman/module.py
@@ -49,13 +49,14 @@ class Module(object):
kid = self.module_spec['provides'][submodule]
kidname = kid['name']
try:
+ kid['module_name'] = '.'.join([mod_name, kid['sourcefile']])
+ except KeyError:
kid['module_name'] = '.'.join([mod_name, kidname])
- except ImportError:
- kid['module_name'] = '.'.join([mod_name, self.name])
- f = self.__module.__file__
- msg = 'Module.__initialize(); module spec is old, missing '\
+ f = self._module.__file__
+ msg = 'Module.__initialize(); %(module)s module spec is old, missing '\
'attribute: \'sourcefile\'.\nBackward compatibility '\
- 'may be removed in the future.\nFile: %(f)s' % {'f': f}
+ 'may be removed in the future.\nFile: %(f)s' % {
+ 'module': self.name, 'f': f}
self.output.warn(msg)
kid['is_imported'] = False
self.kids[kidname] = kid
--
2.8.3

Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ RDEPEND="
>=dev-python/ssl-fetch-0.4[${PYTHON_USEDEP}]
"

PATCHES=(
"${FILESDIR}/layman-2.4.1-sourcefileattributechanges.patch"
)

layman_check_kernel_config() {
local CONFIG_CHECK
use squashfs && CONFIG_CHECK+=" ~BLK_DEV_LOOP ~SQUASHFS"
Expand Down

0 comments on commit 70376e2

Please sign in to comment.