Skip to content

Commit

Permalink
app-editors/emacs: Fix build failure with 17.0 profiles.
Browse files Browse the repository at this point in the history
The following comment from upstream is in configure.ac of emacs-25.3:
"-no-pie or -nopie fixes a temacs segfault on Gentoo, OpenBSD, Ubuntu,
and other systems with "hardened" GCC configurations for some reason
(Bug#18784).  We don't know why this works, but not segfaulting is
better than segfaulting."

Adding -no-pie to 23.4 and 24.5 appears to make them build, too.
Note that only append-ldflags fixes the build failure, while
append-flags does not (at least not for 23.4).

Thanks to Mats Lidell for pointing me to the above upstream comment.

Closes: https://bugs.gentoo.org/639568
Closes: https://bugs.gentoo.org/639570
Package-Manager: Portage-2.3.17, Repoman-2.3.6
  • Loading branch information
ulm committed Dec 10, 2017
1 parent 487553d commit 7b54f92
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions app-editors/emacs/emacs-23.4-r16.ebuild
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ src_configure() {
strip-flags
filter-flags -fstrict-aliasing -pie
append-flags $(test-flags -fno-strict-aliasing)
append-ldflags $(test-flags -no-pie) #639568

if use sh; then
replace-flags "-O[1-9]" -O0 #262359
Expand Down
1 change: 1 addition & 0 deletions app-editors/emacs/emacs-24.5-r4.ebuild
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ src_prepare() {
src_configure() {
strip-flags
filter-flags -pie #526948
append-ldflags $(test-flags -no-pie) #639570

if use sh; then
replace-flags "-O[1-9]" -O0 #262359
Expand Down

0 comments on commit 7b54f92

Please sign in to comment.