Skip to content

Commit

Permalink
app-mobilephone/smssend, dev-libs/skyutils: fix SSLv3 support.
Browse files Browse the repository at this point in the history
In commits 790eacc and ac28332, I added an "sslv3" USE flag to
dev-libs/skyutils and revisioned app-mobilephone/smssend to depend on
it. This fix was insufficient; any other programs linking to
libskyutils would suffer the same problem, as Michał Górny pointed
out.

Two new revisions of the affected packages remove the "sslv3" option
for dev-libs/skyutils, and make it depend on openssl[sslv3] when the
user asks for SSL support. Note: this required the removal of LibreSSL
support on skyutils. The new revision of app-mobilephone/smssend now
depends on the fixed revision of skyutils.

An additional fix was made, and now smssend depends on
skyutils[ssl]. Without SSL support in libskyutils, many SMS providers
simply don't work.

Gentoo-Bug: 588326
  • Loading branch information
orlitzky committed Aug 7, 2016
1 parent 8341c0a commit 8b119a6
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ SLOT="0"
KEYWORDS="~amd64 ~ppc ~ppc64 ~sparc ~x86"
IUSE=""

DEPEND=">=dev-libs/skyutils-2.7[sslv3]"
# -r5 of skyutils fixes a runtime crash, bug 588326.
# Without SSL support in skyutils, some providers fail.
DEPEND=">=dev-libs/skyutils-2.8-r5[ssl]"
RDEPEND="${DEPEND}"

PATCHES=( "${FILESDIR}/${P}-verizon.diff" )
Expand Down
6 changes: 0 additions & 6 deletions dev-libs/skyutils/metadata.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,4 @@
This library contains many useful functions such as chained lists,
string manipulation, socket, and the HTTP protocol.
</longdescription>

<use>
<flag name="sslv3">
Require OpenSSL to be built with the old SSLv3 protocol enabled.
</flag>
</use>
</pkgmetadata>
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,9 @@ SRC_URI="mirror://gentoo/${P}.tar.gz"
LICENSE="LGPL-2.1+"
SLOT="0"
KEYWORDS="~amd64 ~ppc ~ppc64 ~sparc ~x86"
IUSE="libressl ssl sslv3"
REQUIRED_USE="sslv3? ( ssl? ( !libressl ) )"
IUSE="ssl"

DEPEND="ssl? (
!libressl? ( dev-libs/openssl:0=[sslv3?] )
libressl? ( dev-libs/libressl:0= )
)"
DEPEND="ssl? ( dev-libs/openssl:0=[sslv3] )"
RDEPEND="${DEPEND}"

PATCHES=(
Expand Down

0 comments on commit 8b119a6

Please sign in to comment.