Skip to content

Commit

Permalink
dev-lang/perl: Combine -Dd_u32align definitions, add HPPA
Browse files Browse the repository at this point in the history
Although unaligned accesses are not fatal on PARISC, as they are
automatically realigned as they occur, this has a non-trivial impact on
performance that ought to be fixed upstream. Work around it the same way
sparc*-* does and combine both efforts into a single myconf() call.

Package-Manager: Portage-2.3.75, Repoman-2.3.17
Bug: https://bugs.gentoo.org/676062
Signed-off-by: Jeroen Roovers <[email protected]>
  • Loading branch information
Jeroen Roovers committed Sep 11, 2019
1 parent d155a49 commit 8cda541
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 6 deletions.
5 changes: 3 additions & 2 deletions dev-lang/perl/perl-5.28.2-r1.ebuild
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,6 @@ src_configure() {
filter-flags "-flto"

use sparc && myconf -Ud_longdbl
use sparc && myconf -Dd_u32align # bug #676062

export BUILD_BZIP2=0
export BZIP2_INCLUDE=${EROOT}/usr/include
Expand Down Expand Up @@ -469,7 +468,9 @@ src_configure() {

# fix unaligned access misdetection
# https://rt.perl.org/Public/Bug/Display.html?id=133495
[[ ${CHOST} == sparc*-solaris* ]] && myconf "-Dd_u32align='define'"
# bug #676062
use hppa || use sparc || [[ ${CHOST} == sparc*-solaris* ]] && \
myconf "-Dd_u32align='define'"

# Prefix: the host system needs not to follow Gentoo multilib stuff, and in
# Prefix itself we don't do multilib either, so make sure perl can find
Expand Down
5 changes: 3 additions & 2 deletions dev-lang/perl/perl-5.28.9999.ebuild
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,6 @@ src_configure() {
filter-flags "-flto"

use sparc && myconf -Ud_longdbl
use sparc && myconf -Dd_u32align # bug #676062

export BUILD_BZIP2=0
export BZIP2_INCLUDE=${EROOT}/usr/include
Expand Down Expand Up @@ -467,7 +466,9 @@ src_configure() {

# fix unaligned access misdetection
# https://rt.perl.org/Public/Bug/Display.html?id=133495
[[ ${CHOST} == sparc*-solaris* ]] && myconf "-Dd_u32align='define'"
# bug #676062
use hppa || use sparc || [[ ${CHOST} == sparc*-solaris* ]] && \
myconf "-Dd_u32align='define'"

# Prefix: the host system needs not to follow Gentoo multilib stuff, and in
# Prefix itself we don't do multilib either, so make sure perl can find
Expand Down
5 changes: 3 additions & 2 deletions dev-lang/perl/perl-5.30.0.ebuild
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,6 @@ src_configure() {
filter-flags "-flto"

use sparc && myconf -Ud_longdbl
use sparc && myconf -Dd_u32align # bug #676062

export BUILD_BZIP2=0
export BZIP2_INCLUDE=${EROOT}/usr/include
Expand Down Expand Up @@ -465,7 +464,9 @@ src_configure() {

# fix unaligned access misdetection
# https://rt.perl.org/Public/Bug/Display.html?id=133495
[[ ${CHOST} == sparc*-solaris* ]] && myconf "-Dd_u32align='define'"
# bug #676062
use hppa || use sparc || [[ ${CHOST} == sparc*-solaris* ]] && \
myconf "-Dd_u32align='define'"

# Prefix: the host system needs not to follow Gentoo multilib stuff, and in
# Prefix itself we don't do multilib either, so make sure perl can find
Expand Down

0 comments on commit 8cda541

Please sign in to comment.