Skip to content

Commit

Permalink
app-crypt/tpm2-tools: Fix broken test exposed in libtpms-0.9.0
Browse files Browse the repository at this point in the history
Package-Manager: Portage-3.0.20, Repoman-3.0.3
Signed-off-by: Christopher Byrne <[email protected]>
Signed-off-by: Ionen Wolkens <[email protected]>
  • Loading branch information
salahcoronya authored and ionenwks committed Oct 6, 2021
1 parent 442ce52 commit 90e9e0d
Show file tree
Hide file tree
Showing 2 changed files with 34 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
From 3d80fad66694ad14a58dd89204a25e9248c4ab0c Mon Sep 17 00:00:00 2001
From: Jonas Witschel <[email protected]>
Date: Wed, 29 Sep 2021 17:08:07 +0200
Subject: [PATCH] testparms: fix condition for negative test

Commit e858dec76686bb4c42e74e0984b433231e530f93 ("testparms: ensure curve not
supported before negative test") is supposed to ensure that the negative test
is run only if ecc521 is *not* supported, but instead it runs the negative test
if ecc521 is *available*. This worked anyway for libtpms < 0.9.0 because camellia
was not supported, but since libtpms 0.9.0 added support for this algorithm, the
test suite fails now with swtpm.

Signed-off-by: Jonas Witschel <[email protected]>
---
test/integration/tests/testparms.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/integration/tests/testparms.sh b/test/integration/tests/testparms.sh
index 8c3548e5..a587a60a 100644
--- a/test/integration/tests/testparms.sh
+++ b/test/integration/tests/testparms.sh
@@ -63,7 +63,7 @@ else
fi

# Attempt to specify a suite that is not supported (error from TPM)
-if tpm2 getcap ecc-curves | grep -q TPM2_ECC_NIST_P521; then
+if ! tpm2 getcap ecc-curves | grep -q TPM2_ECC_NIST_P521; then
if tpm2 testparms "ecc521:ecdsa:camellia" &>/dev/null; then
echo "tpm2 testparms succeeded while it shouldn't or TPM failed"
exit 1
--
2.32.0

1 change: 1 addition & 0 deletions app-crypt/tpm2-tools/tpm2-tools-5.2.ebuild
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ BDEPEND="virtual/pkgconfig

PATCHES=(
"${FILESDIR}/${PN}-5.1.1-no-efivar-automagic.patch"
"${FILESDIR}/${PN}-5.2-testparms-fix-condition-for-negative-test.patch"
)

src_prepare() {
Expand Down

0 comments on commit 90e9e0d

Please sign in to comment.