net-firewall/pglinux: [QA] unconditionally install logrotate files

QA policy [0] says that we don't conditionalise installation of small files. It's a wasteful rebuild and inconsistent across packages for when users desire completions to be available. [0] https://projects.gentoo.org/qa/policy-guide/installed-files.html#pg0301 Signed-off-by: Sam James <[email protected]>
johu · Jul 31, 2021 · ab8b0d3 · ab8b0d3
1 parent 1a1d605
commit ab8b0d3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/net-firewall/pglinux/metadata.xml b/net-firewall/pglinux/metadata.xml
@@ -10,7 +10,6 @@
 	</upstream>
 	<use>
 		<flag name="cron">Install cron script</flag>
-		<flag name="logrotate">Install logrotate.d file</flag>
 	</use>
 	<longdescription lang="en">
 	PeerGuardian Linux (pgl) is a privacy oriented firewall application. It blocks

diff --git a/...ll/pglinux/pglinux-2.3.1_p20171006.ebuild → ...pglinux/pglinux-2.3.1_p20171006-r1.ebuild b/...ll/pglinux/pglinux-2.3.1_p20171006.ebuild → ...pglinux/pglinux-2.3.1_p20171006-r1.ebuild
@@ -15,7 +15,7 @@ SRC_URI="https://sourceforge.net/code-snapshots/git/p/pe/peerguardian/code.git/p
 LICENSE="GPL-3"
 SLOT="0"
 KEYWORDS="~amd64 ~x86"
-IUSE="cron dbus logrotate networkmanager qt5 zlib"
+IUSE="cron dbus networkmanager qt5 zlib"
 REQUIRED_USE="qt5? ( dbus )"
 
 DEPEND="
@@ -35,7 +35,6 @@ RDEPEND="${DEPEND}
 	net-firewall/iptables
 	sys-apps/sysvinit
 	cron? ( virtual/cron )
-	logrotate? ( app-admin/logrotate )
 	networkmanager? ( net-misc/networkmanager:= )
 "
 BDEPEND="
@@ -77,9 +76,9 @@ src_configure() {
 		--with-iconsdir=/usr/share/icons/hicolor/128x128/apps
 		--with-gentoo-init
 		--localstatedir=/var
+		--enable-logrotate
 		$(use_enable cron)
 		$(use_enable dbus)
-		$(use_enable logrotate)
 		$(use_enable networkmanager)
 		$(use_with qt5)
 		LRELEASE=$(qt5_get_bindir)/lrelease