Skip to content

Commit

Permalink
dev-libs/aws-c-common: Remove -Werror from build FLAGS
Browse files Browse the repository at this point in the history
Issue: dev-libs/aws-c-common-0.4.57 uses -Werror for build.
Discovered on: amd64 (internal ref: ci)

-Werror is not recommended for releases and should always be disabled
when encountered in build-logs, because there are numerous cases
where this breaks without purpose.

Closes: https://bugs.gentoo.org/745093
Package-Manager: Portage-3.0.8, Repoman-3.0.1
Signed-off-by: Sven Eden <[email protected]>
Signed-off-by: Joonas Niilola <[email protected]>
  • Loading branch information
Yamakuzure authored and juippis committed Sep 30, 2020
1 parent 2ead775 commit ac98037
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ IUSE="static-libs test"

RESTRICT="!test? ( test )"

PATCHES=(
"${FILESDIR}"/${P}-remove-Werror-CFLAG.patch
)

src_configure() {
local mycmakeargs=(
-DBUILD_SHARED_LIBS=$(usex !static-libs)
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
--- a/cmake/AwsCFlags.cmake 2020-09-29 09:19:28.820584526 +0200
+++ b/cmake/AwsCFlags.cmake 2020-09-29 09:19:36.068584784 +0200
@@ -48,7 +48,7 @@
list(APPEND AWS_C_FLAGS "${_FLAGS}")

else()
- list(APPEND AWS_C_FLAGS -Wall -Werror -Wstrict-prototypes)
+ list(APPEND AWS_C_FLAGS -Wall -Wstrict-prototypes)

if(NOT SET_PROPERTIES_NO_WEXTRA)
list(APPEND AWS_C_FLAGS -Wextra)

0 comments on commit ac98037

Please sign in to comment.