Skip to content

Commit

Permalink
media-video/mpv: notify users about new OSC layout since 0.21.0 in 9999
Browse files Browse the repository at this point in the history
Nobody complained about new OSC layout since 0.21.0 (October 2016).
Thus don't bother ~arch users with it, but be nice to stable users.

Update softvol message to point to Gentoo wiki instead of bugzilla.
Gentoo mpv wiki page suffered a complete rewrite and became useful.
Version constraint at this point can be relaxed to just 0.18.1.

Package-Manager: Portage-2.3.3, Repoman-2.3.1
Closes: gentoo#3718
  • Loading branch information
Coacher authored and SoapGentoo committed Jan 29, 2017
1 parent 3b957ab commit ddccc15
Showing 1 changed file with 16 additions and 9 deletions.
25 changes: 16 additions & 9 deletions media-video/mpv/mpv-9999.ebuild
Original file line number Diff line number Diff line change
Expand Up @@ -298,23 +298,30 @@ pkg_preinst() {
}

pkg_postinst() {
local rv softvol_0_18_1=0
local rv softvol_0_18_1=0 osc_0_21_0=0

for rv in ${REPLACING_VERSIONS}; do
version_compare ${rv} 0.18.1-r1
version_compare ${rv} 0.18.1
[[ $? -eq 1 ]] && softvol_0_18_1=1
version_compare ${rv} 0.21.0
[[ $? -eq 1 ]] && osc_0_21_0=1
done

if [[ ${softvol_0_18_1} -eq 1 ]]; then
elog "Starting from version 0.18.1 the software volume control is"
elog "enabled by default, see:"
elog "https://github.com/mpv-player/mpv/blob/v0.18.1/DOCS/interface-changes.rst"
elog "https://github.com/mpv-player/mpv/issues/3322"
elog
elog "Since version 0.18.1 the software volume control is always enabled."
elog "This means that volume controls don't change the system volume,"
elog "e.g. per-application volume with PulseAudio."
elog "If you want to restore the old behaviour, please refer to"
elog "If you want to restore the previous behaviour, please refer to"
elog
elog "https://wiki.gentoo.org/wiki/Mpv#Volume_in_0.18.1"
elog
fi

if [[ ${osc_0_21_0} -eq 1 ]]; then
elog "In version 0.21.0 the default OSC layout was changed."
elog "If you want to restore the previous layout, please refer to"
elog
elog "https://bugs.gentoo.org/show_bug.cgi?id=588492#c7"
elog "https://wiki.gentoo.org/wiki/Mpv#OSC_in_0.21.0"
elog
fi

Expand Down

0 comments on commit ddccc15

Please sign in to comment.