Skip to content

Commit

Permalink
known amendments: reword fixTokenRemint warning
Browse files Browse the repository at this point in the history
  • Loading branch information
mDuo13 authored Nov 1, 2023
1 parent ec0caa7 commit 8299910
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion content/resources/known-amendments.md
Original file line number Diff line number Diff line change
Expand Up @@ -688,7 +688,7 @@ Amendment `fixNFTokenRemint` would change the way NFT sequence numbers are const

The amendment also introduces a new account deletion restriction. An account can only be deleted if `FirstNFTSequence` + `MintedNFTokens` + 256 is less than the current ledger sequence (256 was chosen as a heuristic restriction for account deletion and already exists in the account deletion constraint). Without this restriction, an NFT could still be re-minted under certain conditions.

**Warning:** This is a **breaking change** for projects & tools relying on their own locally computed NFTokenID for minted tokens. As this fix changes the way a TokenID is calculated, without updating local code the wrong NFTokenIDs will be generated locally. A [well known reference implementation in JavaScript](https://gist.github.com/N3TC4T/a20fb528931ed009ebdd708be4938748?permalink_comment_id=4738760#gistcomment-4738760) can easily be patched with backwards compatibillity.
**Warning:** This is a **breaking change** for projects & tools relying on their own locally computed NFTokenID for minted tokens. If you have code to calculate NFTokenIDs, you must update it to match the new fomula. For an example of how to do so with backwards compatibility, see this [well known reference implementation in JavaScript](https://gist.github.com/N3TC4T/a20fb528931ed009ebdd708be4938748?permalink_comment_id=4738760#gistcomment-4738760).


### fixNonFungibleTokensV1_2
Expand Down

0 comments on commit 8299910

Please sign in to comment.