-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.4] Archive content #38953
[4.4] Archive content #38953
Conversation
I rebased this to j4.3 since we try to only have bug fixes in patch releases. |
This is a bug fix. I deliberately submitted this to 4.2 as a bug fix. |
array codestyle updated |
@Quy should be fixed now |
good spot @Quy should be fixed now |
Co-authored-by: Quy <[email protected]>
I have tested this item 🔴 unsuccessfully on a32f990 Tested in Joomla 4.1 with PHP 8.1.22 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38953. |
@brianteeman i tried to test this but i'm not seeing what option you're talking about that should still be displayed even when toggled to hide. Everything hides even before patch. Am i missing something? |
I have tested this item ✅ successfully on a32f990 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38953. |
1 similar comment
I have tested this item ✅ successfully on a32f990 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38953. |
This pull request has been automatically rebased to 4.4-dev. |
I have tested this item 🔴 unsuccessfully on 373bc12 Using menu item options:Successfully Test:Change option
|
@brianteeman can you have a look at this PR and see if you can get this ready? |
Closing for now as I dont have the available time to look into it |
Pull Request for Issue #38952 .
Summary of Changes
Archive Content view does not obey all the article options. Amongst other reasons this is because it was not using the layout
Testing Instructions
Create a new article in a new category
set the article to archive
Create a menu item for archived articles
Test the article options in the menu item to hide/show category, date, details etc
Before
All the optoins work except for the hide article details
After
All works as expected
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed