Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Privacy: Allow MFA and invalid privacy consents #44522

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Nov 24, 2024

Pull Request for Issue #42783, #38791.

Summary of Changes

When a user has no valid privacy consent and has MFA enabled, they are stuck in an endless redirect loop.

Testing Instructions

  1. Setup a user with MFA
  2. Enable the privacyconsent system plugin
  3. Login with that user in the frontend

Actual result BEFORE applying this Pull Request

Endless redirect loop between captive view and profile edit view.

Expected result AFTER applying this Pull Request

MFA captive view is displayed and you can type in a MFA code.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@pe7er
Copy link
Contributor

pe7er commented Dec 18, 2024

I have tested this item ✅ successfully on e02d12b

I was able to reproduce the issue: I ended up in an endless loop and could not login. In Firefox I got this message:
Screenshot from 2024-12-19 00-01-17

After the patch I was able to login.
And the Privacy Policy consent option is displayed in the User Profile
Screenshot from 2024-12-19 00-02-30


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44522.

@alikon
Copy link
Contributor

alikon commented Dec 19, 2024

without pr
image

with pr
I was able to login.

@alikon
Copy link
Contributor

alikon commented Dec 19, 2024

I have tested this item ✅ successfully on e02d12b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44522.

@alikon
Copy link
Contributor

alikon commented Dec 19, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44522.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 19, 2024
@bembelimen bembelimen enabled auto-merge (squash) December 19, 2024 09:45
@bembelimen bembelimen merged commit 37b1408 into joomla:5.2-dev Dec 19, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 19, 2024
@Hackwar Hackwar deleted the 5.2-privacy-requirereset branch December 19, 2024 10:13
@pe7er pe7er added this to the Joomla! 5.2.3 milestone Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants