Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2][CLI] extension:remove -n option "Invalid Response" fix #44546

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Nov 28, 2024

Pull Request for Issue #44445 .

Summary of Changes

check if "no-interaction"

Testing Instructions

php joomla.php extension:remove ID -n

Actual result BEFORE applying this Pull Request

[WARNING] Invalid response
and the extension is not removed

Expected result AFTER applying this Pull Request

the extension is removed

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Quy
Copy link
Contributor

Quy commented Nov 30, 2024

I have tested this item ✅ successfully on 002eb9c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44546.

@pe7er
Copy link
Contributor

pe7er commented Dec 18, 2024

I have tested this item ✅ successfully on 002eb9c

I was able to reproduce this issue:
Screenshot from 2024-12-19 00-19-33

The PR fixes it:
Screenshot from 2024-12-19 00-20-04


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44546.

@pe7er pe7er added the RTC This Pull Request is Ready To Commit label Dec 18, 2024
@pe7er
Copy link
Contributor

pe7er commented Dec 18, 2024

RTC

@joomla-cms-bot joomla-cms-bot removed RTC This Pull Request is Ready To Commit bug PR-5.2-dev labels Dec 18, 2024
@alikon
Copy link
Contributor Author

alikon commented Dec 19, 2024

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44546.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 19, 2024
@Hackwar Hackwar enabled auto-merge (squash) December 19, 2024 08:26
@Hackwar Hackwar merged commit 1b283d8 into joomla:5.2-dev Dec 19, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 19, 2024
@alikon alikon deleted the patch-21 branch December 19, 2024 09:38
@Hackwar Hackwar added this to the Joomla! 5.2.3 milestone Dec 19, 2024
@Hackwar
Copy link
Member

Hackwar commented Dec 19, 2024

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants