Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh changelog URL on manifest cache refresh #44565

Merged
merged 2 commits into from
Dec 21, 2024

Conversation

AlterBrains
Copy link
Contributor

Summary of Changes

Currently, extension manifest cache refresh doesn't update <changelogurl>

Testing Instructions

Add or change <changelogurl>https://site.com</changelogurl> in any extension manifest XML.
Refresh manifest cache.

Actual result BEFORE applying this Pull Request

changelogurl in #__extensions table is not updated.

Expected result AFTER applying this Pull Request

changelogurl in #__extensions table is updated.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Ruud68
Copy link
Contributor

Ruud68 commented Dec 2, 2024

Just mentioning this one here as I did the same PR but that wasn't accepted. Maybe some valid comments in there: I do not know, been a long time since. #40056

@AlterBrains
Copy link
Contributor Author

@Ruud68 This PR is about refresh, not update. Here is PR for update, I've added your issue ID:
#44564

@alikon
Copy link
Contributor

alikon commented Dec 8, 2024

I have tested this item ✅ successfully on 18f33b8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44565.

@Hackwar
Copy link
Member

Hackwar commented Dec 21, 2024

I have tested this item ✅ successfully on 18f33b8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44565.

@Hackwar
Copy link
Member

Hackwar commented Dec 21, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44565.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 21, 2024
@pe7er pe7er enabled auto-merge (squash) December 21, 2024 09:45
@pe7er pe7er merged commit eb04630 into joomla:5.2-dev Dec 21, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 21, 2024
@pe7er pe7er added this to the Joomla! 5.2.3 milestone Dec 21, 2024
@pe7er
Copy link
Contributor

pe7er commented Dec 21, 2024

Thanks @AlterBrains !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants