Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issues with deepMap #3266

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
+259 −42
Open

Performance issues with deepMap #3266

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7b10e01
Faster deepMap recurse
dvd101x Sep 16, 2024
c7d98df
Callback with right number of arguments.
dvd101x Sep 16, 2024
8324f63
Removed return in forEach
dvd101x Sep 16, 2024
0aad351
Merge branch 'develop' into deepMap-2
josdejong Sep 18, 2024
9c42720
Clone with slice
dvd101x Sep 19, 2024
2ec54ad
Added index benchmarks
dvd101x Sep 19, 2024
81f6d76
Format
dvd101x Sep 20, 2024
edc61eb
Optimize callback returns the number of arguments
dvd101x Sep 20, 2024
9f80b90
Added tests for callbacks with three arguments.
dvd101x Sep 20, 2024
a5618b5
optimizeCallback returns a non typed function.
dvd101x Sep 21, 2024
c7a4210
Optimize recursre functions by mapping the last dimension.
dvd101x Oct 1, 2024
488628c
Merge branch 'develop' into deepMap-2
dvd101x Dec 6, 2024
3a44e32
Merge branch 'develop' into deepMap-2
dvd101x Dec 16, 2024
f98a164
Updated tests
dvd101x Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added tests for callbacks with three arguments.
  • Loading branch information
@dvd101x
dvd101x committed Sep 20, 2024
commit 9f80b901e6cb12e49279748d356ea65d77b3586b
12 changes: 12 additions & 0 deletions test/benchmark/forEach.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,18 @@ new Benchmark.Suite()
.add(pad('forEach(genericMatrix, abs+idx)'), () => {
forEach(genericMatrix, (x, idx) => abs(x) + idx[0] - idx[1])
})
.add(pad('genericMatrix.forEach(abs+idx+arr)'), () => {
genericMatrix.forEach((x, idx, X) => abs(x) + idx[0] - idx[1] + X.get([0, 0]))
})
.add(pad('numberMatrix.forEach(abs+idx+arr)'), () => {
numberMatrix.forEach((x, idx, X) => abs(x) + idx[0] - idx[1] + X.get([0, 0]))
})
.add(pad('forEach(genericMatrix, abs+idx+arr)'), () => {
forEach(genericMatrix, (x, idx, X) => abs(x) + idx[0] - idx[1] + X.get([0, 0]))
})
.add(pad('forEach(array, abs+idx+arr)'), () => {
forEach(array, (x, idx, X) => abs(x) + idx[0] - idx[1] + X[0][0])
})
.add()
.on('cycle', function (event) {
console.log(String(event.target))
Expand Down
9 changes: 9 additions & 0 deletions test/benchmark/map.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,15 @@ new Benchmark.Suite()
.add(pad('numberMatrix.map(abs + idx)'), () => {
numberMatrix.map((x, idx) => abs(x) + idx[0] - idx[1])
})
.add(pad('map(array, abs + idx + arr)'), () => {
map(array, (x, idx, X) => abs(x) + idx[0] - idx[1] + X[0][0])
})
.add(pad('genericMatrix.map(abs + idx + matrix)'), () => {
genericMatrix.map((x, idx, X) => abs(x) + idx[0] - idx[1] + X.get([0, 0]))
})
.add(pad('numberMatrix.map(abs + idx + matrix)'), () => {
numberMatrix.map((x, idx, X) => abs(x) + idx[0] - idx[1] + X.get([0, 0]))
})
.on('cycle', function (event) {
console.log(String(event.target))
})
Expand Down