drm/amdgpu: fix another missing fence reference in the CS code

drm_sched_job_add_dependency() consumes the references of the gang members. Only triggered by mesh shaders. Signed-off-by: Christian König <[email protected]> Fixes: 1728baa ("drm/amdgpu: use scheduler dependencies for CS") Tested-by: Mike Lothian <[email protected]> Tested-by: Bert Karwatzki <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] Reviewed-by: Alex Deucher <[email protected]> Reviewed-by: Luben Tuikov <[email protected]>
josf · Jan 5, 2023 · ed21f6c · ed21f6c
1 parent 83e79ae
commit ed21f6c
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
@@ -1254,9 +1254,12 @@ static int amdgpu_cs_submit(struct amdgpu_cs_parser *p,
 			continue;
 
 		fence = &p->jobs[i]->base.s_fence->scheduled;
+		dma_fence_get(fence);
 		r = drm_sched_job_add_dependency(&leader->base, fence);
-		if (r)
+		if (r) {
+			dma_fence_put(fence);
 			goto error_cleanup;
+		}
 	}
 
 	if (p->gang_size > 1) {