Skip to content

Commit

Permalink
cephadm: Remove assignment to member variable in ServiceSpecs
Browse files Browse the repository at this point in the history
Remove unnecessary assignment to member variable 'preview_only', this is done in the constructor of the derived ServiceSpec class.

Fixes: https://tracker.ceph.com/issues/47384

Signed-off-by: Volker Theile <[email protected]>
  • Loading branch information
votdev committed Sep 9, 2020
1 parent e0b2970 commit 6443ac5
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions src/python-common/ceph/deployment/service_spec.py
Original file line number Diff line number Diff line change
Expand Up @@ -589,8 +589,6 @@ def __init__(self,
#: RADOS namespace where NFS client recovery data is stored in the pool.
self.namespace = namespace

self.preview_only = preview_only

def validate(self):
super(NFSServiceSpec, self).validate()

Expand Down Expand Up @@ -660,7 +658,6 @@ def __init__(self,
self.rgw_frontend_ssl_certificate = rgw_frontend_ssl_certificate
self.rgw_frontend_ssl_key = rgw_frontend_ssl_key
self.ssl = ssl
self.preview_only = preview_only

def get_port(self):
if self.rgw_frontend_port:
Expand Down Expand Up @@ -724,7 +721,6 @@ def __init__(self,
self.api_secure = api_secure
self.ssl_cert = ssl_cert
self.ssl_key = ssl_key
self.preview_only = preview_only

if not self.api_secure and self.ssl_cert and self.ssl_key:
self.api_secure = True
Expand Down

0 comments on commit 6443ac5

Please sign in to comment.