Skip to content

Commit

Permalink
switch i386 memstick installer images to MBR
Browse files Browse the repository at this point in the history
Some BIOSes have trouble booting from GPT in non-UEFI mode.  This is
commonly reported with Lenovo laptops, including my x220.  As we do not
currently support booting FreeBSD/i386 via UEFI there's no reason to
prefer GPT.

The "vestigial swap partition" was added in r265017 to work around an
issue with loader's GPT support, so we should not need it when using
MBR.

We may want to make the same change to amd64, although the issue there is
mitigated by such systems booting via UEFI in the common case.

PR:		227422
Reviewed by:	gjb
MFC after:	3 weeks
Relnotes:	Yes
Sponsored by:	The FreeBSD Foundation
  • Loading branch information
emaste committed Apr 12, 2018
1 parent 14c2e3b commit 717780f
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions release/i386/make-memstick.sh
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,9 @@ makefs -B little -o label=FreeBSD_Install -o version=2 ${2}.part ${1}
rm ${1}/etc/fstab
rm ${1}/etc/rc.conf.local

mkimg -s gpt \
-b ${1}/boot/pmbr \
-p freebsd-boot:=${1}/boot/gptboot \
-p freebsd-ufs:=${2}.part \
-p freebsd-swap::1M \
mkimg -s mbr \
-b ${1}/boot/mbr \
-p freebsd:-"mkimg -s bsd -b ${1}/boot/boot -p freebsd-ufs:=${2}.part" \
-o ${2}
rm ${2}.part

0 comments on commit 717780f

Please sign in to comment.