Maintenance: Update dependency rubocop to v1.45.1

jouvin · Feb 9, 2023 · f7743cf · f7743cf
1 parent 963df10
commit f7743cf
Show file tree

Hide file tree

Showing 11 changed files with 16 additions and 16 deletions.
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -445,7 +445,7 @@ GEM
       ffi (~> 1.0)
     rchardet (1.8.0)
     redis (4.8.0)
-    regexp_parser (2.6.2)
+    regexp_parser (2.7.0)
     rexml (3.2.5)
     rspec-core (3.12.0)
       rspec-support (~> 3.12.0)
@@ -467,7 +467,7 @@ GEM
       rspec-core (> 3.3)
     rspec-support (3.12.0)
     rszr (1.3.0)
-    rubocop (1.44.1)
+    rubocop (1.45.1)
       json (~> 2.3)
       parallel (~> 1.10)
       parser (>= 3.2.0.0)

diff --git a/app/models/channel/email_parser.rb b/app/models/channel/email_parser.rb
@@ -128,8 +128,8 @@ def process(channel, msg, exception = true)
 
     message = "Can't process email, you will find it for bug reporting under #{filename}, please create an issue at https://github.com/zammad/zammad/issues"
 
-    p "ERROR: #{message}" # rubocop:disable Rails/Output
-    p "ERROR: #{e.inspect}" # rubocop:disable Rails/Output
+    p "ERROR: #{message}" # rubocop:disable Rails/Output, Lint/Debugger
+    p "ERROR: #{e.inspect}" # rubocop:disable Rails/Output, Lint/Debugger
     Rails.logger.error message
     Rails.logger.error e
 

diff --git a/lib/github/credentials.rb b/lib/github/credentials.rb
@@ -3,7 +3,7 @@
 class GitHub
   class Credentials
 
-    QUERY = <<-'GRAPHQL'.freeze
+    QUERY = <<-GRAPHQL.freeze
       query {
         viewer {
           login

diff --git a/lib/github/linked_issue.rb b/lib/github/linked_issue.rb
@@ -8,7 +8,7 @@ class LinkedIssue
       'CLOSED' => 'closed'
     }.freeze
 
-    QUERY = <<-'GRAPHQL'.freeze
+    QUERY = <<-GRAPHQL.freeze
       query($repositor_owner: String!, $repository_name: String!, $issue_id: Int!) {
        repository(owner: $repositor_owner, name: $repository_name) {
          issue(number: $issue_id) {

diff --git a/lib/gitlab/credentials.rb b/lib/gitlab/credentials.rb
@@ -3,7 +3,7 @@
 class GitLab
   class Credentials
 
-    QUERY = <<-'GRAPHQL'.freeze
+    QUERY = <<-GRAPHQL.freeze
       query {
         currentUser {
           username

diff --git a/lib/gitlab/linked_issue.rb b/lib/gitlab/linked_issue.rb
@@ -7,7 +7,7 @@ class LinkedIssue
       'opened' => 'open'
     }.freeze
 
-    QUERY = <<-'GRAPHQL'.freeze
+    QUERY = <<-GRAPHQL.freeze
       query($fullpath: ID!, $issue_id: String) {
         project(fullPath: $fullpath) {
           issue(iid: $issue_id) {

diff --git a/spec/lib/generators/zammad/translation_catalog/extractor/chat_spec.rb b/spec/lib/generators/zammad/translation_catalog/extractor/chat_spec.rb
@@ -13,7 +13,7 @@
 
   context 'with strings to be found' do
     let(:string) do
-      <<~'CODE'
+      <<~CODE
         var value = {
           title: 'My title',
           scrollHint: "My scroll hint",

diff --git a/spec/lib/generators/zammad/translation_catalog/extractor/form_js_spec.rb b/spec/lib/generators/zammad/translation_catalog/extractor/form_js_spec.rb
@@ -13,7 +13,7 @@
 
   context 'with strings to be found' do
     let(:string) do
-      <<~'CODE'
+      <<~CODE
         var value = {
           display: 'My display',
           placeholder: "My placeholder",

diff --git a/spec/lib/generators/zammad/translation_catalog/extractor/frontend_spec.rb b/spec/lib/generators/zammad/translation_catalog/extractor/frontend_spec.rb
@@ -13,7 +13,7 @@
 
   context 'with strings to be found' do
     let(:string) do
-      <<~'CODE'
+      <<~CODE
         __('__ String')
         App.i18n.translateContent('String')
         App.i18n.translateInline('Inline string')

diff --git a/spec/rubocop/cop/zammad/migration_scheduler_last_run_spec.rb b/spec/rubocop/cop/zammad/migration_scheduler_last_run_spec.rb
@@ -6,7 +6,7 @@
 RSpec.describe RuboCop::Cop::Zammad::MigrationSchedulerLastRun, type: :rubocop do
 
   it 'shows no error for create_if_not_exists when last_run is set' do
-    expect_no_offenses(<<-'RUBY')
+    expect_no_offenses(<<-RUBY)
     Scheduler.create_if_not_exists(
       name:          "Clean up 'DataPrivacyTask'.",
       method:        'DataPrivacyTask.cleanup',
@@ -21,7 +21,7 @@
   end
 
   it 'shows error for create_if_not_exists when last_run is not set' do
-    result = inspect_source(<<~'RUBY')
+    result = inspect_source(<<~RUBY)
       Scheduler.create_if_not_exists(
         name:          "Clean up 'DataPrivacyTask'.",
         method:        'DataPrivacyTask.cleanup',
@@ -37,7 +37,7 @@
   end
 
   it 'shows no error for create_or_update when last_run is set' do
-    expect_no_offenses(<<-'RUBY')
+    expect_no_offenses(<<-RUBY)
     Scheduler.create_or_update(
       name:          "Clean up 'DataPrivacyTask'.",
       method:        'DataPrivacyTask.cleanup',
@@ -52,7 +52,7 @@
   end
 
   it 'shows error for create_or_update when last_run is not set' do
-    result = inspect_source(<<~'RUBY')
+    result = inspect_source(<<~RUBY)
       Scheduler.create_or_update(
         name:          "Clean up 'DataPrivacyTask'.",
         method:        'DataPrivacyTask.cleanup',

diff --git a/spec/support/graphql.rb b/spec/support/graphql.rb
@@ -177,7 +177,7 @@ def error_message
       private
 
       def assert(message)
-        raise "Assertion '#{message}' failed, graphql result:\n#{PP.pp(payload, '')}" if !yield
+        raise "Assertion '#{message}' failed, graphql result:\n#{PP.pp(payload, '')}" if !yield # rubocop:disable Lint/Debugger
       end
     end
-Original file line number
+Diff line change
@@ Expand Up / @@ -177,7 +177,7 @@ def error_message @@
           private
           def assert(message)
-            raise "Assertion '#{message}' failed, graphql result:\n#{PP.pp(payload, '')}" if !yield
+            raise "Assertion '#{message}' failed, graphql result:\n#{PP.pp(payload, '')}" if !yield # rubocop:disable Lint/Debugger
           end
         end
@@ Expand Down @@