Skip to content

Commit

Permalink
memory: omap-gpmc: add error message if bank-width property is absent
Browse files Browse the repository at this point in the history
Instead of failing silently log a hint for the dt author about the
reason of the failure.

Signed-off-by: Uwe Kleine-König <[email protected]>
Acked-by: Roger Quadros <[email protected]>
Signed-off-by: Tony Lindgren <[email protected]>
  • Loading branch information
Uwe Kleine-König authored and tmlind committed May 31, 2017
1 parent 95c278b commit c9eabf4
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion drivers/memory/omap-gpmc.c
Original file line number Diff line number Diff line change
Expand Up @@ -2083,8 +2083,11 @@ static int gpmc_probe_generic_child(struct platform_device *pdev,
} else {
ret = of_property_read_u32(child, "bank-width",
&gpmc_s.device_width);
if (ret < 0)
if (ret < 0) {
dev_err(&pdev->dev, "%s has no 'bank-width' property\n",
child->full_name);
goto err;
}
}

/* Reserve wait pin if it is required and valid */
Expand Down

0 comments on commit c9eabf4

Please sign in to comment.