ShortenFullyQualifiedTypeReferences should not modify Javadoc

jprinet · Apr 22, 2023 · 5eed2ba · 5eed2ba
1 parent ca1cdbd
commit 5eed2ba
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 0 deletions.
diff --git a/...t/src/test/java/org/openrewrite/java/cleanup/ShortenFullyQualifiedTypeReferencesTest.java b/...t/src/test/java/org/openrewrite/java/cleanup/ShortenFullyQualifiedTypeReferencesTest.java
@@ -246,6 +246,23 @@ class T {
         );
     }
 
+    @Test
+    void dontModifyJavadoc() {
+        rewriteRun(
+          java(
+            """
+              /**
+               * See {@link java.util.List}.
+               *
+               * @see java.util.List
+               */
+              class T {
+              }
+              """
+          )
+        );
+    }
+
     @Test
     void conflictExistingImport() {
         rewriteRun(

diff --git a/...-java/src/main/java/org/openrewrite/java/cleanup/ShortenFullyQualifiedTypeReferences.java b/...-java/src/main/java/org/openrewrite/java/cleanup/ShortenFullyQualifiedTypeReferences.java
@@ -22,6 +22,7 @@
 import org.openrewrite.java.tree.J;
 import org.openrewrite.java.tree.JavaSourceFile;
 import org.openrewrite.java.tree.JavaType;
+import org.openrewrite.java.tree.Space;
 
 import java.time.Duration;
 import java.util.HashMap;
@@ -99,6 +100,12 @@ public J visitImport(J.Import impoort, ExecutionContext ctx) {
                 return impoort;
             }
 
+            @Override
+            public Space visitSpace(Space space, Space.Location loc, ExecutionContext ctx) {
+                // stop recursion into Javadoc comments
+                return space;
+            }
+
             @Override
             public J visitFieldAccess(J.FieldAccess fieldAccess, ExecutionContext ctx) {
                 JavaType type = fieldAccess.getType();