flatpak-transaction: Squash error propagation and fix return value

It doesn’t look like this error path is taken very often. Spotted while reading through the code. This function is opportunistically looking for dependencies, so a failure in one remote shouldn’t make the whole operation fail. Signed-off-by: Philip Withnall <[email protected]>
jpwhiting · Jun 16, 2021 · a7af60f · a7af60f
1 parent f2b4edc
commit a7af60f
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/common/flatpak-transaction.c b/common/flatpak-transaction.c
@@ -2199,8 +2199,8 @@ search_for_dependency (FlatpakTransaction  *self,
       state = flatpak_transaction_ensure_remote_state (self, FLATPAK_TRANSACTION_OPERATION_INSTALL, remote, NULL, &local_error);
       if (state == NULL)
         {
-          g_debug ("Can't get state for remote %s: %s", remote, local_error->message);
-          return FALSE;
+          g_debug ("Can't get state for remote %s, ignoring: %s", remote, local_error->message);
+          continue;
         }
 
       if (flatpak_remote_state_lookup_ref (state, flatpak_decomposed_get_ref (runtime_ref), NULL, NULL, NULL, NULL, NULL))