Skip to content

Commit

Permalink
Merge pull request ampproject#853 from eshannon3/eshannon3/fix-header…
Browse files Browse the repository at this point in the history
…-id to 0.6 branch

Remove erroneous hash from id on amp-wp-header
  • Loading branch information
westonruter committed Jan 10, 2018
2 parents 309af3d + b71935c commit ed5594b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ Follow along with or [contribute](https://github.com/Automattic/amp-wp/blob/deve
- Fix Polldaddy amd SoundCloud embeds. Add vanilla WordPress "embed" test page. A new `bin/create-embed-test-post.php` wp-cli script is introduced. See [#829](https://github.com/Automattic/amp-wp/pull/829). Props kienstra, westonruter, ThierryA.
- Merge AMP Customizer into main Customizer. See [#819](https://github.com/Automattic/amp-wp/pull/819). Props kaitnyl, westonruter.
- Update AMP HTML tags and attributes. A new `bin/amphtml-update.sh` bash script is introduced. Fixes Playbuzz. See [#823](https://github.com/Automattic/amp-wp/pull/823). Props kienstra, ThierryA, westonruter.
- Remove erroneous hash from id on amp-wp-header. See [#853](https://github.com/Automattic/amp-wp/pull/853). Props eshannon3.

See [0.6 milestone](https://github.com/Automattic/amp-wp/milestone/5?closed=1).

Expand Down
1 change: 1 addition & 0 deletions readme.txt
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ Follow along with or [contribute](https://github.com/Automattic/amp-wp/blob/deve
- Fix Polldaddy amd SoundCloud embeds. Add vanilla WordPress "embed" test page. A new `bin/create-embed-test-post.php` wp-cli script is introduced. See [#829](https://github.com/Automattic/amp-wp/pull/829). Props kienstra, westonruter, ThierryA.
- Merge AMP Customizer into main Customizer. See [#819](https://github.com/Automattic/amp-wp/pull/819). Props kaitnyl, westonruter.
- Update AMP HTML tags and attributes. A new `bin/amphtml-update.sh` bash script is introduced. Fixes Playbuzz. See [#823](https://github.com/Automattic/amp-wp/pull/823). Props kienstra, ThierryA, westonruter.
- Remove erroneous hash from id on amp-wp-header. See [#853](https://github.com/Automattic/amp-wp/pull/853). Props eshannon3.

See [0.6 milestone](https://github.com/Automattic/amp-wp/milestone/5?closed=1).

Expand Down
2 changes: 1 addition & 1 deletion templates/header-bar.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
*/

?>
<header id="#top" class="amp-wp-header">
<header id="top" class="amp-wp-header">
<div>
<a href="<?php echo esc_url( $this->get( 'home_url' ) ); ?>">
<?php $site_icon_url = $this->get( 'site_icon_url' ); ?>
Expand Down

0 comments on commit ed5594b

Please sign in to comment.