Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding some Highcharts JS themes #29

Merged
merged 3 commits into from
Dec 17, 2014
Merged

Adding some Highcharts JS themes #29

merged 3 commits into from
Dec 17, 2014

Conversation

jbkunst
Copy link
Contributor

@jbkunst jbkunst commented Dec 17, 2014

Hi jrnold,

Time ago I writed a post about a Highcharts theme in ggplot2 and I have a few feedback comments and one of them was about to make a pull request to your package, so here I am.

About the commits I have made:

  1. Add R/hc.R file which contains the theme. The template was wsj.R
  2. Modify NAMESPACE and DESCRIPTON files. R/ggthemes-data.R to add the backgroud colors and palletes. There are for now 2 themes: defaul, and darkunica.
  3. I tried modify vignettes/children/examples.RMD but I can't compile the readme.md (makefile) :(!

Well, that's it. Tell me what you think.

Thanks in advance. Have a nice day.

@jrnold jrnold merged commit 910403a into jrnold:master Dec 17, 2014
@jrnold
Copy link
Owner

jrnold commented Dec 17, 2014

Thanks! I merged in the changes.

I made a few changes to theme_hc. I am trying to be consistent in having all theme_* functions have base_size and base_family as their 1st two arguments. Additionally, I thought that bgcolor was a more informative argument name than theme.

@jbkunst
Copy link
Contributor Author

jbkunst commented Dec 18, 2014

It's fine, no problem. Thank you too.

@jrnold
Copy link
Owner

jrnold commented Dec 18, 2014

Thanks, again! The new version should be up on CRAN soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants