Fix logical expression in parenthesis

Fixes mathiasbynens#39. Closes mathiasbynens#40.
jrtitus · Aug 23, 2016 · 5157c09 · 5157c09
1 parent de4b36c
commit 5157c09
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/luamin.js b/luamin.js
@@ -210,7 +210,8 @@
 		var needsParens = base.inParens && (
 			type == 'BinaryExpression' ||
 			type == 'FunctionDeclaration' ||
-			type == 'TableConstructorExpression'
+			type == 'TableConstructorExpression' ||
+			type == 'LogicalExpression'
 		);
 		if (needsParens) {
 			result += '(';

diff --git a/tests/tests.js b/tests/tests.js
@@ -491,6 +491,11 @@
 				'description': 'MemberExpression + CallExpression on a TableConstructorExpression',
 				'original': 'x = ({ foo = print }).foo("test")',
 				'minified': 'x=({foo=print}).foo("test")'
+			},
+			{
+				'description': 'LogicalExpression in parenthesis + MemberExpression + CallExpression',
+				'original': '(x or y):f()',
+				'minified': '(x or y):f()'
 			}
 		],