fix: No maxLength label is displayed for arrays of items Redocly#1701 (…

…Redocly#1765) * fix: No maxLength label is displayed for arrays of items Redocly#1701 * Revert "fix: No maxLength label is displayed for arrays of items Redocly#1701" This reverts commit 543ecc4. * fix: No maxLength label is displayed for arrays of items Redocly#1701 * change array items display * fix alignment * remove theme font from labels * update snapshot Co-authored-by: Oprysk <[email protected]>
jrub · Jan 5, 2022 · 6c7685e · 6c7685e
1 parent 2474b76
commit 6c7685e
Show file tree

Hide file tree

Showing 19 changed files with 551 additions and 359 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -17,7 +17,7 @@ module.exports = {
  version: 'detect',
  },
  },
- plugins: ['@typescript-eslint', 'import'],
+ plugins: ['react', 'react-hooks', '@typescript-eslint', 'import'],
  rules: {
  '@typescript-eslint/explicit-function-return-type': 'off',
  '@typescript-eslint/explicit-module-boundary-types': 'off',
@@ -31,6 +31,8 @@ module.exports = {
  '@typescript-eslint/no-var-requires': 'off',
 
  'react/prop-types': 'off',
+ 'react-hooks/rules-of-hooks': 'error',
+ 'react-hooks/exhaustive-deps': 'warn',
 
  'import/no-extraneous-dependencies': 'error',
  'import/no-internal-modules': [

diff --git a/.github/workflows/publish-cli.yml b/.github/workflows/publish-cli.yml
@@ -5,53 +5,52 @@ on:
  branches:
  - master
 
-
 jobs:
  bundle:
- needs: [ check-version-cli ]
+ needs: [check-version-cli]
  if: needs.check-version-cli.outputs.changed == 'true'
  runs-on: ubuntu-latest
  steps:
- - uses: actions/checkout@v2
- - uses: actions/setup-node@v2
- - name: Cache node modules
- uses: actions/cache@v2
- with:
- path: ~/.npm # npm cache files are stored in `~/.npm` on Linux/macOS
- key: npm-${{ hashFiles('package-lock.json') }}
- restore-keys: |
- npm-${{ hashFiles('package-lock.json') }}
- npm-
- - run: npm ci
- - run: npm run bundle
- - name: Store bundle artifact
- uses: actions/upload-artifact@v2
- with:
- name: bundles-cli
- path: bundles
- retention-days: 1
+  - uses: actions/checkout@v2
+  - uses: actions/setup-node@v2
+  - name: Cache node modules
+  uses: actions/cache@v2
+  with:
+  path: ~/.npm # npm cache files are stored in `~/.npm` on Linux/macOS
+  key: npm-${{ hashFiles('package-lock.json') }}
+  restore-keys: |
+  npm-${{ hashFiles('package-lock.json') }}
+  npm-
+  - run: npm ci
+  - run: npm run bundle
+  - name: Store bundle artifact
+  uses: actions/upload-artifact@v2
+  with:
+  name: bundles-cli
+  path: bundles
+  retention-days: 1
  unit-tests:
- needs: [ check-version-cli ]
+ needs: [check-version-cli]
  if: needs.check-version-cli.outputs.changed == 'true'
  runs-on: ubuntu-latest
  steps:
- - uses: actions/checkout@v1
- - run: npm ci
- - run: npm test
+  - uses: actions/checkout@v1
+  - run: npm ci
+  - run: npm test
  e2e-tests:
- needs: [ bundle ]
+ needs: [bundle]
  runs-on: ubuntu-latest
  steps:
- - uses: actions/checkout@v1
- - run: npm ci
- - name: Download bundled artifact
- uses: actions/download-artifact@v2
- with:
- name: bundles-cli
- path: bundles
- - run: npm run e2e
+  - uses: actions/checkout@v1
+  - run: npm ci
+  - name: Download bundled artifact
+  uses: actions/download-artifact@v2
+  with:
+  name: bundles-cli
+  path: bundles
+  - run: npm run e2e
  bundle-cli:
- needs: [ check-version-cli ]
+ needs: [check-version-cli]
  if: needs.check-version-cli.outputs.changed == 'true'
  runs-on: ubuntu-latest
  steps:
@@ -99,7 +98,7 @@ jobs:
  steps:
  - uses: actions/setup-node@v1
  with:
- node-version: "14.x"
+ node-version: '14.x'
  registry-url: 'https://registry.npmjs.org'
  - uses: actions/checkout@v2
  - name: Download cli bundled artifact

diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -9,42 +9,42 @@ jobs:
  bundle:
  runs-on: ubuntu-latest
  steps:
- - uses: actions/checkout@v2
- - uses: actions/setup-node@v2
- - name: Cache node modules
- uses: actions/cache@v2
- with:
- path: ~/.npm # npm cache files are stored in `~/.npm` on Linux/macOS
- key: npm-${{ hashFiles('package-lock.json') }}
- restore-keys: |
- npm-${{ hashFiles('package-lock.json') }}
- npm-
- - run: npm ci
- - run: npm run bundle
- - name: Store bundle artifact
- uses: actions/upload-artifact@v2
- with:
- name: bundles
- path: bundles
- retention-days: 1
+  - uses: actions/checkout@v2
+  - uses: actions/setup-node@v2
+  - name: Cache node modules
+  uses: actions/cache@v2
+  with:
+  path: ~/.npm # npm cache files are stored in `~/.npm` on Linux/macOS
+  key: npm-${{ hashFiles('package-lock.json') }}
+  restore-keys: |
+  npm-${{ hashFiles('package-lock.json') }}
+  npm-
+  - run: npm ci
+  - run: npm run bundle
+  - name: Store bundle artifact
+  uses: actions/upload-artifact@v2
+  with:
+  name: bundles
+  path: bundles
+  retention-days: 1
  unit-tests:
  runs-on: ubuntu-latest
  steps:
- - uses: actions/checkout@v1
- - run: npm ci
- - run: npm test
+  - uses: actions/checkout@v1
+  - run: npm ci
+  - run: npm test
  e2e-tests:
  needs: [bundle]
  runs-on: ubuntu-latest
  steps:
- - uses: actions/checkout@v1
- - run: npm ci
- - name: Download bundled artifact
- uses: actions/download-artifact@v2
- with:
- name: bundles
- path: bundles
- - run: npm run e2e
+  - uses: actions/checkout@v1
+  - run: npm ci
+  - name: Download bundled artifact
+  uses: actions/download-artifact@v2
+  with:
+  name: bundles
+  path: bundles
+  - run: npm run e2e
  # disable this for now
  # deploy-demo:
  # needs: [bundle, unit-tests, e2e-tests]
@@ -76,7 +76,7 @@ jobs:
  steps:
  - uses: actions/setup-node@v1
  with:
- node-version: "14.x"
+ node-version: '14.x'
  registry-url: 'https://registry.npmjs.org'
  - uses: actions/checkout@v2
  - name: Download bundled artifacts

diff --git a/demo/webpack.config.ts b/demo/webpack.config.ts
@@ -37,6 +37,7 @@ export default (env: { playground?: boolean; bench?: boolean } = {}, { mode }) =
  port: 9090,
  hot: true,
  historyApiFallback: true,
+ open: true,
  },
  stats: {
  children: true,

diff --git a/e2e/integration/search.e2e.ts b/e2e/integration/search.e2e.ts
@@ -56,7 +56,7 @@ describe('Search', () => {
 
  it('should show proper message when no search results are found', () => {
  getSearchResults().should('not.exist');
- getSearchInput().type('xzss', {force: true});
+ getSearchInput().type('xzss', { force: true });
  getSearchResults().should('exist').should('contain', 'No results found');
- })
+ });
 });