Do not escape code contents. Closes mixmark-io#198

js-mk · Oct 25, 2017 · 0881337 · 0881337
1 parent 2b65cd5
commit 0881337
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 6 deletions.
diff --git a/README.md b/README.md
@@ -46,6 +46,10 @@ Options can be passed in to the constructor on instantiation.
 | `linkStyle`           | `inlined` or `referenced` | `inlined` |
 | `linkReferenceStyle`  | `full`, `collapsed`, or `shortcut` | `full` |
 
+## Methods
+
+
+
 ## License
 
 turndown is copyright © 2017+ Dom Christie and released under the MIT license.
diff --git a/src/node.js b/src/node.js
@@ -3,6 +3,7 @@ import { isBlock } from './utilities'
 export default function Node (node) {
   node.isBlock = isBlock(node)
   node.isVoid = isVoid(node)
+  node.isCode = node.nodeName.toLowerCase() === 'code' || node.parentNode.isCode
   node.isBlank = isBlank(node)
   node.flankingWhitespace = flankingWhitespace(node)
   return node

diff --git a/src/turndown.js b/src/turndown.js
@@ -94,15 +94,15 @@ TurndownService.prototype = {
    */
 
   process: function process (parentNode) {
-    var _this = this
+    var self = this
     return reduce.call(parentNode.childNodes, function (output, node) {
       node = new Node(node)
 
       var replacement = ''
       if (node.nodeType === 3) {
-        replacement = _this.escape(node.nodeValue)
+        replacement = node.isCode ? node.nodeValue : self.escape(node.nodeValue)
       } else if (node.nodeType === 1) {
-        replacement = _this.replacementForNode(node)
+        replacement = self.replacementForNode(node)
       }
 
       return join(output, replacement)

diff --git a/test/index.html b/test/index.html
@@ -58,6 +58,16 @@
   <pre class="expected">``There is a literal backtick (`) here``</pre>
 </div>
 
+<div class="case" data-name="code containing markdown syntax">
+  <div class="input"><code>_emphasis_</code></div>
+  <pre class="expected">`_emphasis_`</pre>
+</div>
+
+<div class="case" data-name="code containing markdown syntax in a span">
+  <div class="input"><code><span>_emphasis_</span></code></div>
+  <pre class="expected">`_emphasis_`</pre>
+</div>
+
 <div class="case" data-name="h1">
   <div class="input"><h1>Level One Heading</h1></div>
   <pre class="expected">Level One Heading

diff --git a/test/turndown-test.browser.js b/test/turndown-test.browser.js
@@ -651,6 +651,7 @@ function htmlParser () {
 function Node (node) {
   node.isBlock = isBlock(node);
   node.isVoid = isVoid$1(node);
+  node.isCode = node.nodeName.toLowerCase() === 'code' || node.parentNode.isCode;
   node.isBlank = isBlank(node);
   node.flankingWhitespace = flankingWhitespace(node);
   return node
@@ -804,15 +805,15 @@ TurndownService.prototype = {
    */
 
   process: function process (parentNode) {
-    var _this = this;
+    var self = this;
     return reduce.call(parentNode.childNodes, function (output, node) {
       node = new Node(node);
 
       var replacement = '';
       if (node.nodeType === 3) {
-        replacement = _this.escape(node.nodeValue);
+        replacement = node.isCode ? node.nodeValue : self.escape(node.nodeValue);
       } else if (node.nodeType === 1) {
-        replacement = _this.replacementForNode(node);
+        replacement = self.replacementForNode(node);
       }
 
       return join(output, replacement)